Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rest config and rest config checker #2432

Merged
merged 14 commits into from
Feb 13, 2025
Merged

feat: add rest config and rest config checker #2432

merged 14 commits into from
Feb 13, 2025

Conversation

joaoandre-avaiga
Copy link
Collaborator

@joaoandre-avaiga joaoandre-avaiga commented Jan 29, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add option to inform rest server Host, Port and other attributes that could be used for a deploy in a production environment.

Related Tickets & Documents

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

  • This solution meets the acceptance criteria of the related issue.
  • The related issue checklist is completed.
  • This PR adds unit tests for the developed code. If not, why?
  • End-to-End tests have been added or updated. If not, why?
  • The documentation has been updated, or a dedicated issue created. (If applicable)
  • The release notes have been updated? (If applicable)

@joaoandre-avaiga joaoandre-avaiga force-pushed the feature/#421-support-rest-production-env branch from b620c8c to e7536bf Compare January 29, 2025 00:57
jrobinAV
jrobinAV requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring is needed. You can have a look at the taipy/core/config/__init__.py and taipy/core/config/core_section.py files

@jrobinAV jrobinAV added 🖧 Devops Operations, monitoring, maintenance, deployment, packaging ⚙️Configuration Related to Taipy Configuration Core: Rest API Related to Rest APIs 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general labels Jan 29, 2025
jrobinAV
jrobinAV reviewed Jan 31, 2025
View reviewed changes
@jrobinAV jrobinAV self-assigned this Feb 7, 2025
@jrobinAV jrobinAV self-requested a review February 11, 2025 18:10
@jrobinAV jrobinAV merged commit 14d6981 into develop Feb 13, 2025
126 checks passed
@jrobinAV jrobinAV deleted the feature/#421-support-rest-production-env branch February 13, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrobinAV jrobinAV Awaiting requested review from jrobinAV

Assignees

@jrobinAV jrobinAV

@joaoandre-avaiga joaoandre-avaiga

Labels
⚙️Configuration Related to Taipy Configuration Core: Rest API Related to Rest APIs 🖧 Devops Operations, monitoring, maintenance, deployment, packaging 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support production environment for taipy-rest
2 participants
@joaoandre-avaiga @jrobinAV