Added examples for progress control #1809
Open
+286
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
FabienLelaquais
commented
Sep 19, 2024
FabienLelaquais
commented
- removed 'color' property from progress control
- added CSS class names for value and title in the control
- minor refman issues
+ removed 'color' property from progress control + added CSS class names for value and title in the control + minor refman issues
FabienLelaquais
added
📈 Improvement
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 87.65% (+0.01% 🔼) |
3193/3643 |
| 🟡 | Branches | 68.9% (-0.12% 🔻) |
2173/3154 |
| 🟢 | Functions | 82.67% (+0.02% 🔼) |
582/704 |
| 🟢 | Lines | 88.22% (+0.01% 🔼) |
2957/3352 |
Test suite run success
640 tests passing in 43 suites.
Report generated by 🧪jest coverage report action from d3b758b
FredLL-Avaiga
approved these changes
Sep 19, 2024
| ("width", PropertyType.string_or_number), | ||
| ] | ||
| ) | ||
| ._set_propagate(), |
There was a problem hiding this comment.
don't think propagate is needed here as there's no variable modification from the frontend
There was a problem hiding this comment.
Let's discuss this rapidly. I'm sure you're right.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.