-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple traces with new decimator api (#1062) #1731
multiple traces with new decimator api (#1062) #1731
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 87.61% | 3230/3687 |
🟡 | Branches | 68.91% | 2214/3213 |
🟢 | Functions | 83.26% | 597/717 |
🟢 | Lines | 88.15% | 2990/3392 |
Test suite run success
645 tests passing in 43 suites.
Report generated by 🧪jest coverage report action from c05b75d
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
This PR has been closed because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity. |
Is this normal that this was closed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the two new parameters for Decimator and inherited classes.
That will be brought back the day after 4.0 is out.
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
Co-authored-by: Fabien Lelaquais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolve #1062
Resolve #1515
This new api will also enable the use of applying the decimator directly to an existing dataframe -> use for plotly charts