Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple traces with new decimator api (#1062) #1731

Merged
merged 16 commits into from
Oct 7, 2024

Conversation

dinhlongviolin1
Copy link
Member

@dinhlongviolin1 dinhlongviolin1 commented Aug 30, 2024

Resolve #1062

Resolve #1515

This new api will also enable the use of applying the decimator directly to an existing dataframe -> use for plotly charts

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 68.90756302521008%

St.
Category Percentage Covered / Total
🟢 Statements 87.61% 3230/3687
🟡 Branches 68.91% 2214/3213
🟢 Functions 83.26% 597/717
🟢 Lines 88.15% 2990/3392

Test suite run success

645 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from c05b75d

@dinhlongviolin1 dinhlongviolin1 added 📈 Improvement Improvement of a feature. 📝Release Notes Impacts the Release Notes labels Aug 31, 2024
Copy link
Contributor

This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Sep 15, 2024
Copy link
Contributor

This PR has been closed because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot closed this Sep 29, 2024
@FlorianJacta
Copy link
Member

Is this normal that this was closed?

@FredLL-Avaiga FredLL-Avaiga reopened this Sep 30, 2024
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Sep 30, 2024
@jrobinAV jrobinAV added the 🟥 Priority: Critical Must be addressed as soon as possible label Oct 4, 2024
@dinhlongviolin1 dinhlongviolin1 marked this pull request as ready for review October 4, 2024 19:06
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the two new parameters for Decimator and inherited classes.
That will be brought back the day after 4.0 is out.

frontend/taipy-gui/src/components/Taipy/Chart.tsx Outdated Show resolved Hide resolved
taipy/gui/data/decimator/base.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/__init__.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/base.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/base.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/rdp.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/minmax.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/rdp.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/scatter_decimator.py Outdated Show resolved Hide resolved
taipy/gui/data/decimator/scatter_decimator.py Outdated Show resolved Hide resolved
FabienLelaquais
FabienLelaquais previously approved these changes Oct 7, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Oct 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19015 16462 87% 0% 🟢

New Files

File Coverage Status
taipy/gui/data/decimator/base.py 54% 🟢
TOTAL 54% 🟢

Modified Files

File Coverage Status
taipy/gui/data/init.py 100% 🟢
taipy/gui/data/decimator/init.py 100% 🟢
taipy/gui/data/decimator/lttb.py 95% 🟢
taipy/gui/data/decimator/minmax.py 96% 🟢
taipy/gui/data/decimator/rdp.py 92% 🟢
taipy/gui/data/decimator/scatter_decimator.py 78% 🟢
taipy/gui/data/pandas_data_accessor.py 81% 🟢
TOTAL 92% 🟢

updated for commit: 9912af8 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dinhlongviolin1 dinhlongviolin1 merged commit aa2f888 into develop Oct 7, 2024
129 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the feature/#1062-decimator-multiple-traces branch October 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to use decimator on Plotly charts BUG - Decimator does not work with multiple traces
5 participants