Fix/#62-reactivate-skipped-multisheet-excel-test #63
Conversation
| out_dn2.write(None) | ||
| assert isinstance(out_dn2.read(), list) | ||
| assert len(out_dn2.read()) == 0 | ||
| assert all(compare_custom_date(custom_data[sheet], out_dn2.read()[sheet]) for sheet in self.SHEETS) |
There was a problem hiding this comment.
DO we know why this does not work? I believe it is something we want to work, no?
There was a problem hiding this comment.
No, this is copy pasted from other tests.
On multisheet excel, we can only write data as a dict with keys are sheet name.
There was a problem hiding this comment.
How do you write an empty file, then?
out_dn2.write({}) like that?
I would prefer to make it possible to write None data regardless of the datanode storage type or exposed type. I don't know if it is feasible.
There was a problem hiding this comment.
yes, we can have a test that write empty data in a form of a dictionary
There was a problem hiding this comment.
@jrobinAV We don't have tests that write empty on taipy. What do you think about adding the tests on taipy instead of here?
Resolves #62