-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/#508 change Pipeline and PipelineConfig documentation #535
feature/#508 change Pipeline and PipelineConfig documentation #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes propsed.
data nodes together. It can also be broken down to smaller graphs for execution by defining a `Sequence^`. | ||
A sequence is a subset of tasks derives from the scenario's set of tasks, forming a smaller executable DAG that | ||
can be submitted separately from the scenario DAG. A scenario can also contain a set of additional data nodes | ||
outside of the scenario DAG to represent additional data related to the scenario but are not executable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the need for the "but are not executable" fragment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FabienLelaquais The additional DNs are for data that are related to the scenario but are not part of the DAG, so they are not submittable. Hence not executable 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course they are not. That's my point. Why even mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I wanted to make it clear that it doesn't belong to the DAG as we did mention before that, a DAG is a collection of tasks and datanodes. So I'm afraid user might be confused if they should provide the data nodes again aside from the task for the DAG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is that indeed, tasks are executable. In a sense, sequences and scenarios are as well.
But unless you understood nothing, data nodes never will be.
The addition of "[data nodes] [...] are not executable" really seems strange here. Is similar to saying: "Oh by the way, giraffes cannot talk.".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see what you meant, then how about "A scenario can also contain a set of additional data nodes that are not part of the scenario DAG to represent additional data related to the scenario."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
data nodes together. It can also be broken down to smaller graphs for execution by defining a `Sequence^`. | ||
A sequence is a subset of tasks derives from the scenario's set of tasks, forming a smaller executable DAG that | ||
can be submitted separately from the scenario DAG. A scenario can also contain a set of additional data nodes | ||
outside of the scenario DAG to represent additional data related to the scenario but are not executable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is that indeed, tasks are executable. In a sense, sequences and scenarios are as well.
But unless you understood nothing, data nodes never will be.
The addition of "[data nodes] [...] are not executable" really seems strange here. Is similar to saying: "Oh by the way, giraffes cannot talk.".
…-config-documentation
#508
Note: This is a series of changes to taipy-doc regarding the removal of PipelineConfig, Model and Repositories topic. I will break it down so section level (concept, config, entities) and create a PR for each section to keep the changes minimal and relevant so as not to block any restructuring work being done by others.