Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odyssey: Fix moment locale for en-us #94738

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Sep 19, 2024

Slack: p1726784616274179-slack-C04UE0ANHDY

Proposed Changes

  • Only replace php date format for simple sites

Why are these changes being made?

  • Fix date format for self hosted sites

Testing Instructions

  • Build Odyssey Stats locally
  • Open /wp-admin/admin.php?page=stats#!/stats/day/jasper1.au.ngrok.io?page=stats&flags=stats%2Fdate-picker-calendar
  • Open date range picker
  • Ensure the inputs look good
Before: After:
image image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@kangzj kangzj added the Stats Everything related to our analytics product at /stats/ label Sep 19, 2024
@kangzj kangzj requested review from candy02058912, annacmc and a team September 19, 2024 23:03
@kangzj kangzj self-assigned this Sep 19, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@kangzj kangzj marked this pull request as ready for review September 19, 2024 23:05
@kangzj kangzj added the Odyssey Stats Calypso Stats in Jetpack label Sep 19, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 19, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/moment-locale-for-en-us on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@annacmc annacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, nice fix. Just noted 2x typos in the constant naming that need to be fixed up.

apps/odyssey-stats/src/app.tsx Outdated Show resolved Hide resolved
apps/odyssey-stats/src/app.tsx Outdated Show resolved Hide resolved
@annacmc annacmc merged commit cc7fb4c into trunk Sep 20, 2024
11 checks passed
@annacmc annacmc deleted the fix/moment-locale-for-en-us branch September 20, 2024 03:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024
niranjan-uma-shankar pushed a commit that referenced this pull request Sep 20, 2024
* fix moment locale for en-us

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Odyssey Stats Calypso Stats in Jetpack Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants