Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no purchases URL #94725

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix no purchases URL #94725

wants to merge 1 commit into from

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Sep 19, 2024

Related to #
#94723

Seems that this PR #86263 changed the url for the EmptyComponent.
For a free site the url should lead to the plans in calypso.

Proposed Changes

  • Apply partner link modifications only for isJetpackCloud

Why are these changes being made?

Testing Instructions

  • Choose free site.
  • Go to Upgrades > Purchases
  • Click on the "Upgrade Now" button
  • It should lead to the correct page instead of 404

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@heavyweight heavyweight requested a review from a team as a code owner September 19, 2024 16:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@heavyweight heavyweight added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 19, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants