Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text on site credentials page #94722

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Sep 19, 2024

Related to #94705.

Proposed Changes

  • Updates the title to include WordPress.
  • Updates the subtitle to include migrating to WordPress.com.
  • Updates Site address to Current site address.
  • Updates Skip, I need help providing access to I need help, please contact me.

Screenshot 2024-09-19 at 10 56 39 AM

Why are these changes being made?

  • To minimize the number of people who try to migrate WordPress.com and non-WordPress sites through the migration flow.

Testing Instructions

  • Proceed through the migration flow.
  • On the "How do you want to migrate?" step, choose "Do it for me".
  • Verify that the changes are as described in "Proposed Changes" above.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@donnapep donnapep self-assigned this Sep 19, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@donnapep donnapep linked an issue Sep 19, 2024 that may be closed by this pull request
4 tasks
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@donnapep donnapep requested a review from m1r0 September 19, 2024 15:24
subHeaderText={
isEnglishLocale
? translate(
'Please share the following details to access your site and start your migration to WordPress.com.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the image is "Drop your details below and we'll get started with your migration to WordPress.com.", but your text also looks good. Have we decided to go with this one instead?

@donnapep
Copy link
Contributor Author

The text in the image is "Drop your details below and we'll get started with your migration to WordPress.com

I'm pretty sure the designs are stale, because the "Current" screenshot in the post had stale text as well - p9Jlb4-ee4-p2

@Imran92
Copy link
Contributor

Imran92 commented Sep 19, 2024

The text in the image is "Drop your details below and we'll get started with your migration to WordPress.com

I'm pretty sure the designs are stale, because the "Current" screenshot in the post had stale text as well - p9Jlb4-ee4-p2

You're right, I noticed that too. But just to make sure, I also checked Figma (F8foKv974Gc5dTHSh0i0Wo-fi-396_7998). But it's a small issue and we're making frequent updates here. So I'll just go ahead and approve.

@donnapep donnapep merged commit 2190fff into trunk Sep 19, 2024
14 checks passed
@donnapep donnapep deleted the update/automated-migrations-form-tweaks branch September 19, 2024 18:25
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 19, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16871433

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @donnapep for including a screenshot in the description! This is really helpful for our translators.

niranjan-uma-shankar pushed a commit that referenced this pull request Sep 20, 2024
* Update text on credentials page

* Update tests

* Fix additional test case
@a8ci18n
Copy link

a8ci18n commented Sep 23, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Update static texts on credentials form
4 participants