Fix two issues in devdocs

[gikaragia]

Fixes #94711

Overview

This PR fixes a couple of issues that were observed while testing this PR

The issues were:

• The VerticalMenu wasn't working, see linked issue
• The search state selectors wasn't working.

To reproduce the State Selectors issue:

1. Navigate to https://wpcalypso.wordpress.com/devdocs/selectors
2. Try a search
3. Observe that the results are broken:

Proposed Changes

• Removes twitter which was deprecated from VerticalMenu
• The results returned from the search API now include an item attribute. Updated calling code to use the attribute.

Testing Instructions

• Follow the steps described in VerticalMenu crashes in dev docs #94711 and in the overview above and observe that the issues are solved.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120053

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120053&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-120053&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~3 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-design-playground        -33 B  (-0.0%)       -5 B  (-0.0%)
async-load-design                   -33 B  (-0.0%)       -5 B  (-0.0%)
async-load-docs-selectors           +24 B  (+0.5%)       +8 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[TimBroddin]

The unit tests & E2E tests seem to fail, but unrelated issues (probably flaky tests). You might want to rerun them before merging.

State Selectors:

VericalMenu:

I noticed the usage docs for VerticalMenu still mention twitter. If you want to change it, I'll reapprove.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats
• whats-new
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/docs-issues on your sandbox.

[gikaragia]

Good catch! Fixed!