Sync phone changes with WooPay phone field #9464
Open
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefesouza
requested review from
a team and
leonardola
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +158 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
leonardola
requested changes
Sep 19, 2024
There was a problem hiding this comment.
When I type a Brazilian phone number the country code changes back to US when the input loses focus
Screen.Recording.2024-09-19.at.13.48.49.mov
When I autofill the opt-in phone number the page jumps to the billing address fields
When I autofill the billing address after I typed the opt-in it gets removed
Screen.Recording.2024-09-19.at.13.54.35.mov
When the number gets copied from the billing address it does not change the country flag
Screen.Recording.2024-09-19.at.13.57.15.mov
|
@leonardola fixed on 9b3b991. |
alefesouza
commented
Sep 20, 2024
Comment on lines
+240
to
+252
| // Update the phone number when the billing phone is updated. | ||
| useEffect( () => { | ||
| if ( isCustomerDataUpdating ) { | ||
| setTimeout( () => { | ||
| setPhoneNumber( getPhoneFieldValue() ); | ||
| }, 0 ); | ||
| } | ||
| }, [ | ||
| billingAddressPhone, | ||
| setPhoneNumber, | ||
| getPhoneFieldValue, | ||
| isCustomerDataUpdating, | ||
| ] ); |
There was a problem hiding this comment.
Used this approach due to inconsistencies when using the blur event and autofill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9431
Changes proposed in this Pull Request
When removing the focus of the billing address phone field, automatically update the WooPay phone number.
Testing instructions
Securely save my information for 1-click checkout.Force the pre_check_save_my_info flag (aka Default Opt-in) in the account cache to be true).npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge