-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Parse.ly loader #5863
base: develop
Are you sure you want to change the base?
Simplify Parse.ly loader #5863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5863 +/- ##
=============================================
+ Coverage 29.64% 29.68% +0.03%
Complexity 4760 4760
=============================================
Files 281 281
Lines 20534 20500 -34
=============================================
- Hits 6087 6085 -2
+ Misses 14447 14415 -32 ☔ View full report in Codecov by Sentry. |
Please retry analysis of this Pull-Request directly on SonarCloud |
$should_load = true === $filtered_load_status; | ||
$should_prevent_loading = false === $filtered_load_status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now reads ... weird. But I didn't want to introduce any extra changes to the logic.
Description
We're reducing the number of ways the plugin can be loaded. Eventually there will be only one way (via Integrations) and the rest will be gradually phased out.
Changelog Description
Removed
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test