Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Parse.ly loader #5863

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

rinatkhaziev
Copy link
Contributor

Description

We're reducing the number of ways the plugin can be loaded. Eventually there will be only one way (via Integrations) and the rest will be gradually phased out.

Changelog Description

Removed

  • Removed ability to load Parse.ly via an option.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rinatkhaziev rinatkhaziev requested a review from a team as a code owner September 16, 2024 20:58
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.68%. Comparing base (5bf6176) to head (206c8ef).

Files with missing lines Patch % Lines
wp-parsely.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5863      +/-   ##
=============================================
+ Coverage      29.64%   29.68%   +0.03%     
  Complexity      4760     4760              
=============================================
  Files            281      281              
  Lines          20534    20500      -34     
=============================================
- Hits            6087     6085       -2     
+ Misses         14447    14415      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 18, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Comment on lines +288 to +289
$should_load = true === $filtered_load_status;
$should_prevent_loading = false === $filtered_load_status;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now reads ... weird. But I didn't want to introduce any extra changes to the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant