Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Remote Data Blocks integration #5644

Open
wants to merge 17 commits into
base: cafe-919/update-IntegrationVipConfig-class-to-read-files-in-generic-way
Choose a base branch
from

Conversation

mehmoodak
Copy link
Member

@mehmoodak mehmoodak commented Jun 13, 2024

Description

Adds Remote Data Blocks integration. This integration is dependent on data sources which is handled via data_source_integrations property.

Changelog Description

Added

  • Added "Remote Data Blocks" integration

Pre-review checklist

  • This change works and has been tested locally or in Codespaces.
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • [N/A] This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • Confirm the plugin version before merging.
  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  1. Checkout this PR

  2. Run the vip site locally using vip dev-env start --slug [YOUR_SLUG] (if no env is available then create it)

  3. Create integration config files inside php container and place configs (we have to do it manually because as of now vip dev-env doesn't have support to auto create this folder/file while creating new envs)

    • docker exec -it [CONTAINER_NAME] /bin/sh
    • mkdir /wp/config/integrations-config
    • touch /wp/config/integrations-config/[SLUG]-123-config.php and adds following content (Replace slug with anything)
    <?php
    
    return array(
      'type' => 'slug',
      'label' => 'Slug 123',
      'env' => array(
      	'status' => 'enabled',
            'config' => array (
      		'key' => 'slug-123',
      	)
      )
    );
    
    • touch /wp/config/integrations-config/[SLUG]-456-config.php and adds following content
    <?php
    
    return array(
      'type' => 'slug',
      'label' => 'Slug 456',
      'env' => array(
      	'status' => 'enabled',
            'config' => array (
      		'key' => 'slug-456',
      	)
      )
    );
    
  4. Restart vip dev-env to apply changes in these config files.

  5. Use vip_integration_composable_blocks_config filter to make sure that expected data is returning.

  6. Apart from enabling the plugin via VIP config, customer can also enables it by placing \Automattic\VIP\Integrations\activate( 'remote-data-blocks' ); in plugin-loader.php so please test this also and verify the configs.

@mehmoodak mehmoodak self-assigned this Jun 13, 2024
…s-in-generic-way' into adds-composable-blocks-integration
@mehmoodak mehmoodak force-pushed the cafe-919/update-IntegrationVipConfig-class-to-read-files-in-generic-way branch 3 times, most recently from c5586c6 to 4653616 Compare June 16, 2024 19:04
@mehmoodak mehmoodak changed the title Adds integration of VIP Composable Blocks Adds VIP Composable Blocks as integration Jun 17, 2024
…s-in-generic-way' into adds-composable-blocks-integration
@mehmoodak mehmoodak changed the title Adds VIP Composable Blocks as integration Adds VIP Composable Blocks integration Jun 17, 2024
Copy link

sonarcloud bot commented Jun 20, 2024

…s-in-generic-way' into adds-composable-blocks-integration
@mehmoodak mehmoodak force-pushed the adds-composable-blocks-integration branch from c57129c to f927e13 Compare August 15, 2024 09:59
@mehmoodak mehmoodak force-pushed the adds-composable-blocks-integration branch from f927e13 to d9dca7e Compare August 15, 2024 10:00
@mehmoodak mehmoodak force-pushed the adds-composable-blocks-integration branch from 86dc38e to 7c1e889 Compare August 20, 2024 05:03
Copy link

sonarcloud bot commented Aug 20, 2024

@mehmoodak mehmoodak changed the title Adds VIP Composable Blocks integration Adds Remote Data Blocks integration Aug 20, 2024
@mehmoodak mehmoodak marked this pull request as ready for review August 20, 2024 08:52
@mehmoodak mehmoodak requested a review from a team as a code owner August 20, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants