Add data source doc #79
Merged
+74
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdef
reviewed
Sep 19, 2024
mhsdef
reviewed
Sep 19, 2024
| * | ||
| * @package remote-data-blocks | ||
| * @since 0.1.0 | ||
| */ | ||
| abstract class CompatibleHttpDatasource extends HttpDatasource { | ||
| abstract class CodedHttpDatasource extends HttpDatasource { |
mhsdef
reviewed
Sep 19, 2024
|
|
||
| /** | ||
| * This is a placeholder datasource used only to represent the data source in the | ||
| * settings UI. The actual data loading is implemented by ExampleApiQueryRunner. | ||
| */ | ||
| class ExampleApiDataSource extends HttpDatasource { | ||
| class ExampleApiDataSource implements DatasourceInterface { |
There was a problem hiding this comment.
👍 👍
Yeah, that's the gist of it. Adds flexibility in aligning permutations of abstractions closer to their realities.
mhsdef
approved these changes
Sep 19, 2024
Co-authored-by: Hew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data source doc, and a few fixes that writing the docs helped me find.