Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all sorting options for episode #2175

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Show all sorting options for episode #2175

wants to merge 3 commits into from
+5 −34

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Sep 17, 2024 •
edited
Loading

| 📘 Part of: # |
|:---:|

This PR enables showing all available options for episode sorting by adding TitleAtoZ and TitleZtoA.
This will match the sort options in Android and Web

To test

  1. Start the app
  2. Open a Podcast
  3. Tap on the ... button
  4. Select the Sort row
  5. Check if you see the options to sort for TitleAtoZ and TitleZtoA
  6. Select each of the sorts and see if they sort correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added the [Type] Feature For improving an existing feature or adding a new feature. label Sep 17, 2024
@SergioEstevao SergioEstevao added this to the 7.74 milestone Sep 17, 2024
@SergioEstevao SergioEstevao requested a review from a team as a code owner September 17, 2024 23:07
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team September 17, 2024 23:07
@SergioEstevao SergioEstevao marked this pull request as draft September 17, 2024 23:08
@SergioEstevao SergioEstevao removed the request for review from danielebogo September 17, 2024 23:08
@SergioEstevao SergioEstevao marked this pull request as ready for review September 19, 2024 11:43
@SergioEstevao
Copy link
Contributor Author

@bjtitus can you have into this PR and see why the episode sort options don't update when the newSettingsStorage FF is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjtitus bjtitus Awaiting requested review from bjtitus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Type] Feature For improving an existing feature or adding a new feature.
Projects
None yet
Milestone
7.74
Development

Successfully merging this pull request may close these issues.
1 participant
@SergioEstevao