Disable SPM caching in CI #1989
Conversation
This should be enough to get the Prototype Build step to pass in CI, see failure at https://buildkite.com/automattic/pocket-casts-ios/builds/7634#019113ca-d4bd-4838-b93a-aae0e4a0528f
|
| App Name |  Pocket Casts Prototype Build |
|
| Build Number | pr1989-2fd53e3 | |
| Version | 7.70 | |
| Bundle ID | au.com.shiftyjelly.podcasts.prototype | |
| Commit | 2fd53e3 | |
| App Center Build | Pocket Casts - Prototype Builds #23 |
The pods are not necessary there because the app is not being built.
mokagio
force-pushed
the
mokagio/workaround-double-package.resolved
branch
from
044c13e
to
2fd53e3
Compare
mokagio
changed the title
xcodebuild -resolvePackageDependencies resultThis will allow us to remove the implicit `agents: queue: mac` setting from the pipeline configuration at the Buildkite level, in turn letting us use a standard upload command which supports shared pipeline vars.
This is just so we are on up-to-date tools before making changes that involve said tools.
| export LANG=en_US.UTF-8 | ||
| export LC_ALL=en_US.UTF-8 |
There was a problem hiding this comment.
Do these need to be added to the shared_setup.sh script?
There was a problem hiding this comment.
Good question. I wonder why we needed to export those… and if it's still needed though 🤔
I know that in general, those special env vars sometimes have impacts on some third-party toolds relying on the locale and that it's thus a good practice to set those to en_US.UTF-8 to fix various issues with those… But I have no idea:
- which of the tools we use might have required for us to add those in the past (would have been nice to add a comment back then to leave breadcrumbs 😓
- and thus if it's still necessary (maybe we don't use the tool that had an issue with this anymore, or maybe the CI agents we run our
build.shcommand on now has those env vars already set toen_US.UTF-8at the system level?)
There was a problem hiding this comment.
They were legacy settings coming from the previous automation setup. Unfortunately I don't have additional context on the previous automation.
Those exports triggered some old memories from other projects though, so if I had to guess I'd say they are related to old CocoaPods requirements, e.g. CocoaPods/CocoaPods#6333
There was a problem hiding this comment.
LGTM, with only nitpicks.
Approving to unblock, providing that we don't forget to follow-up with #1990 or any alternative long-term solution for it.
| export LANG=en_US.UTF-8 | ||
| export LC_ALL=en_US.UTF-8 |
There was a problem hiding this comment.
Good question. I wonder why we needed to export those… and if it's still needed though 🤔
I know that in general, those special env vars sometimes have impacts on some third-party toolds relying on the locale and that it's thus a good practice to set those to en_US.UTF-8 to fix various issues with those… But I have no idea:
- which of the tools we use might have required for us to add those in the past (would have been nice to add a comment back then to leave breadcrumbs 😓
- and thus if it's still necessary (maybe we don't use the tool that had an issue with this anymore, or maybe the CI agents we run our
build.shcommand on now has those env vars already set toen_US.UTF-8at the system level?)
Co-authored-by: Olivier Halligon <[email protected]>
mokagio
added
the
[Type] Tooling
This is a temporary workaround to address the SPM-resolution-related build failure in the Prototype Build step, example https://buildkite.com/automattic/pocket-casts-ios/builds/7634#019113ca-d4bd-4838-b93a-aae0e4a0528f.
The long term solution will be one of the two options proposed in #1990
While touching the CI scripts to implement the workaround, I also:
install_cocoapodscallagents: queue: macnode in a few steps, to enable us to remove the implicitagents: queue: macsetting from the pipeline configuration at the Buildkite level, in turn letting us use a standard upload command which supports shared pipeline vars.