Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic handler for requests in APIBaseTask #1387

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Add generic handler for requests in APIBaseTask #1387

wants to merge 1 commit into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Jan 31, 2024

  • Unifies request + response handling for APIBaseTask instead of having individual methods for get, post, and delete.
  • Adds unit tests to verify behavior

To test

Steps to test your PR.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 31, 2024 •
edited
Loading

2 Warnings
⚠️ PR is not assigned to a milestone.
⚠️ No reviewers have been set for this PR yet. Please request a review from @
Automattic/pocket-casts-ios.

Generated by 🚫 Danger

@bjtitus
Add generic handler for requests in APIBaseTask
badf2ce 
Unifies request + response handling for APIBaseTask instead of having individual methods for get, post, and delete.
@bjtitus bjtitus force-pushed the bjtitus/apibasetest-requests branch from d056b1a to badf2ce Compare January 31, 2024 23:52
@danielebogo danielebogo added [Type] Other Issues not covered by other types, such as polish, refactoring and documentation. and removed Refactor labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] Other Issues not covered by other types, such as polish, refactoring and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjtitus @dangermattic @danielebogo