feat: consolidate newsletter editor data and UI #1658

dkoo · 2024-09-13T22:06:44Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR contains changes from #1629, #1630, #1631, and #1632 which were already tested and code reviewed, so it should only require a quick review of the changeset instead of a full code review.

How to test the changes in this Pull Request:

If anything, just ensure that the newsletter editor loads correctly and lets you select/save sender and send list info without any fatals.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

* feat: autocomplete "Send To" UI for CC + AC * fix: sent post statuses for AC * feat: autocomplete send-to UI for Mailchimp * fix: support _n() contacts in AC + CC * refactor: standardize "sent" status checks for all ESPs * fix: function name for CC * fix: set list_type for audiences * fix: extra parentheses for AC * feat: show suggestions on focus * style: move external "Manage" links to button * feat: design updates for autocomplete UI * fix: send to summary * fix: contact counts in send to summary * fix: mailchimp and selected list styles * fix: remove ID from AC segments * fix: logic for contact count in send to summary * fix: parse contact counts as int to avoid "1 contacts" output * fix: translation strings for contact counts in summaries * refactor: standardize use of renderSelectedSummary functions * fix: translatable send-to summaries * fix: allow 0 to be shown * fix: grammar * Update src/service-providers/active_campaign/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/active_campaign/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/constant_contact/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/constant_contact/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/mailchimp/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/mailchimp/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * fix: translatable strings in SendTo component’s selected item label --------- Co-authored-by: leogermani <[email protected]>

…gory (#1630)

* feat: cross-ESP send-lists * refactor: move API namespace and permission callback to main class * refactor: feedback from code review * fix: add missing get/set methods for count and parent_id * refactor: more consistent naming for set_count method * refactor: maintain exception but with WP_Error handling * docs: add more explanation about Send_Lists Co-authored-by: leogermani <[email protected]> * test: improve tests for matching methods * refactor: set values on protected $config var * docs: tweak wording of explanation --------- Co-authored-by: leogermani <[email protected]>

* feat: cross-ESP send-lists * refactor: move API namespace and permission callback to main class * feat: support send lists in provider classes * fix: use getter methods for Send_List classes * chore: clean up register_rest_route configs and permission callbacks * fix: improve error handling for get_send_list methods * fix: add error handling to send-lists API handler

…tead of objects

…rays instead of objects" This reverts commit 3ff1e65.

feat: refactor editor JS to use new standardized data

codecov · 2024-09-16T20:10:21Z

Codecov Report

Attention: Patch coverage is 13.36371% with 1141 lines in your changes missing coverage. Please review.

Project coverage is 21.10%. Comparing base (9980aac) to head (44f3118).
Report is 3 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...mailchimp/class-newspack-newsletters-mailchimp.php	1.36%	289 Missing ⚠️
...ct/class-newspack-newsletters-constant-contact.php	5.62%	235 Missing ⚠️
...ign/class-newspack-newsletters-active-campaign.php	2.85%	204 Missing ⚠️
...or/class-newspack-newsletters-campaign-monitor.php	3.24%	149 Missing ⚠️
includes/class-newspack-newsletters.php	1.49%	66 Missing ⚠️
includes/class-send-lists.php	23.94%	54 Missing ⚠️
...ass-newspack-newsletters-mailchimp-cached-data.php	1.85%	53 Missing ⚠️
...lass-newspack-newsletters-constant-contact-sdk.php	0.00%	26 Missing ⚠️
...wspack-newsletters-service-provider-controller.php	0.00%	17 Missing ⚠️
includes/class-send-list.php	90.00%	14 Missing ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk    #1658      +/-   ##
============================================
+ Coverage     20.82%   21.10%   +0.27%     
- Complexity     2401     2626     +225     
============================================
  Files            46       48       +2     
  Lines          9010     9630     +620     
============================================
+ Hits           1876     2032     +156     
- Misses         7134     7598     +464

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refactor: consolidate ESP data getters into Redux store

…nd-lists

…-lists fix: default sender/send-to for saved layouts BREAKING CHANGE: Existing custom layouts with sender or send-to settings will need to be reconfigured and resaved with desired settings.

miguelpeixe

🎉 🚢 🚀 🎉

dkoo and others added 30 commits August 2, 2024 10:16

Merge branch 'trunk' into epic/update-editor-uis

c83f3b2

Merge branch 'trunk' into epic/update-editor-uis

7a43381

Merge branch 'trunk' into epic/update-editor-uis

a4bbe2a

fix(editor): render notice on sync error (#1606)

0762860

fix(mailchimp): improve sync error messages (#1619)

7bc6ff5

fix(activecampaign): default message on request error (#1618)

612741e

Merge branch 'trunk' into epic/update-editor-uis

6936113

Merge branch 'trunk' into epic/update-editor-uis

f07b7b3

Merge branch 'trunk' into epic/update-editor-uis

05c1e23

feat: cross-ESP send-lists

2df6fef

refactor: move API namespace and permission callback to main class

7c0d36a

feat: support send lists in provider classes

92b3348

feat: refactor editor JS to use new standardized data

b729290

fix: ensure Newsletters plugin blocks are grouped under Newspack cate…

93dc8c5

…gory (#1630)

Merge branch 'trunk' into epic/update-editor-uis

5a44389

Merge branch 'trunk' into epic/update-editor-uis

ada9d71

Merge branch 'epic/update-editor-uis' into feat/send-lists-editor-js

de61ff9

fix: return Send_List objects as arrays from provider methods

c7fc917

fix: avoid unnecessary send-list API requests

3d3430c

chore: remove unneeded methods

0b530bc

fix: fatal error due to get_send_lists returning Send_List arrays ins…

3ff1e65

…tead of objects

Revert "fix: fatal error due to get_send_lists returning Send_List ar…

1f302c3

…rays instead of objects" This reverts commit 3ff1e65.

fix: allow get_send_list methods to return either Send_List[] or arrays

7a48870

fix: correct type for supportedESPs fallback value

be52969

fix(mc): subscriber send count in pre-send modal summary

3ffcd6b

fix: formatting error

a22b721

fix: ensure supported_esps is an array, not an object

c00aca5

dkoo and others added 9 commits September 12, 2024 13:18

fix: missed callable

a43989c

fix: cc error handling

6f85a8b

fix: better error handling for retrieve/sync request errors

f5555c2

refactor: unify retrieve error handling across all ESPs

5627680

refactor: throw error for missing MC creds, too

399cc89

test: update expected exception message

55a7d7f

Merge pull request #1632 from Automattic/feat/send-lists-editor-js

d7ef0c8

feat: refactor editor JS to use new standardized data

refactor: consolidate ESP data getters into Redux store

decefdb

docs: update inline docs for Redux store

bf8b204

dkoo added the [Status] Needs Review label Sep 13, 2024

dkoo self-assigned this Sep 13, 2024

dkoo requested a review from a team as a code owner September 13, 2024 22:06

Merge branch 'trunk' into epic/update-editor-uis

5a43634

dkoo and others added 11 commits September 16, 2024 15:19

Merge branch 'epic/update-editor-uis' into fix/store-improvements

26247f9

fix: move SendTo to Sidebar component; avoid parallel retrieve requests

6c82b6e

refactor: always prefetch sublists on list select

2a28758

fix: account for missing selected list or sublist info

a8e10da

fix: default sender/send-to for saved layouts

b27a3c0

fix: campaign_defaults meta field name

919a4d0

fix: don't overwrite fetched lists/sublists info on retrieve

b27f195

Merge pull request #1657 from Automattic/fix/store-improvements

999829f

refactor: consolidate ESP data getters into Redux store

Merge branch 'epic/update-editor-uis' into fix/layout-defaults-for-se…

2e7497e

…nd-lists

Merge pull request #1633 from Automattic/fix/layout-defaults-for-send…

4fb1e4c

…-lists fix: default sender/send-to for saved layouts BREAKING CHANGE: Existing custom layouts with sender or send-to settings will need to be reconfigured and resaved with desired settings.

fix: force release

9657be1

miguelpeixe approved these changes Sep 18, 2024

View reviewed changes

github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Sep 18, 2024

feat: add link to campaign in provider (#1661)

44f3118

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: consolidate newsletter editor data and UI #1658

feat: consolidate newsletter editor data and UI #1658

dkoo commented Sep 13, 2024

codecov bot commented Sep 16, 2024 •

edited

Loading

miguelpeixe left a comment

feat: consolidate newsletter editor data and UI #1658

Are you sure you want to change the base?

feat: consolidate newsletter editor data and UI #1658

Conversation

dkoo commented Sep 13, 2024

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

codecov bot commented Sep 16, 2024 • edited Loading

Codecov Report

miguelpeixe left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 16, 2024 •

edited

Loading