Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible Plugins update: Remove wpcom-migration, add duplicator-pro #39466

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

villanovachile
Copy link
Contributor

@villanovachile villanovachile commented Sep 19, 2024

Fixes: #1141 & #1105

Proposed changes:

Updates the incompatible plugins array to:

  • add duplicator-pro, which causes fatals on dotcom
  • remove wpcom-migration which is no longer incompatible and will be required for incoming migrations

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Follow the steps to test this branch (should be a comment posted by the bot below)
  • On your WoA dev site, Install wpcom-migration by running the wp-cli command wp plugin install wpcom-migration
  • Navigate to /wp-admin/plugins.php and confirm that the plugin is able to be activated (should not be disabled)
  • Create a dummy plugin in ~/htdocs/wp-content/plugins/duplicator-pro/duplicator-pro.php with the following:
<?php
/**
 * Plugin Name: Duplicator Pro
 * Plugin URI:  http://na.com                     
 * Description: Duplicator Pro dummy plugin
 * Version:     1.0
 * Author:      villanovachile
 * Author URI:  http://na.com     
 */
  • Navigate to /wp-admin/plugins.php and confirm that the plugin is disabled and cannot be activated

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 19, 2024
@villanovachile villanovachile added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 19, 2024
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villanovachile
Copy link
Contributor Author

LGTM!

Now these will need to be added to Calypso. I'lll tag ya there once I got that done. Thanks again!

@villanovachile villanovachile merged commit 5f376c7 into trunk Sep 20, 2024
57 checks passed
@villanovachile villanovachile deleted the add/update-wpcomsh-incompatible-plugins branch September 20, 2024 15:33
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
…ro (#39466)

* Remove wpcom-migraton, add duplicator-pro

* Changelog

---------

Co-authored-by: Daniel Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants