-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Localizations #412
Open
andrewdmontgomery
wants to merge
2
commits into
trunk
Choose a base branch
from
add/merge-localizations
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge Localizations #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
|
@etoledom I updated the description to limit the required testing. It just needs to pass CI. Before we release, we'll want to QA the layouts, etc. But this PR is just to merge in the localizations. The QA should be handled separately. |
etoledom
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description
Note: in the Photo Picker, the
Choose a Photo
andTake a Photo
strings are not yet localized. Those are handled in a separate PR: #400Testing Steps
Necessary Tests
For the Curious
If you're curious, you can check out various localizations. However, any localization bugs will be handled in a separate PR.
App Language
for each schemeNote: Most of the time, you should ignore missing localizations for any Navigation bar items. They will only be localized if the strings are localized by the parent view, which is usaully (but not always) the Demo app. We do not provide any localized strings in the Demo app. There are times, though, where we we use system labels (such as
.done
). In those cases, they will appear localized.Note: The exception to that rule is the
Profile editor with oauth
view. TheDone
button here is provided by the SDK, and should be localized.