Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Localizations #412

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

andrewdmontgomery
Copy link
Contributor

@andrewdmontgomery andrewdmontgomery commented Sep 18, 2024

Closes #

Description

  • Merges localizations
  • Fixes an instance where we weren't using the localized string

Note: in the Photo Picker, the Choose a Photo and Take a Photo strings are not yet localized. Those are handled in a separate PR: #400

Testing Steps

Necessary Tests

  • CI is 🟢

For the Curious

If you're curious, you can check out various localizations. However, any localization bugs will be handled in a separate PR.

  1. Update the App Language for each scheme
    image
  2. Run using each scheme
  3. Check out various views

Note: Most of the time, you should ignore missing localizations for any Navigation bar items. They will only be localized if the strings are localized by the parent view, which is usaully (but not always) the Demo app. We do not provide any localized strings in the Demo app. There are times, though, where we we use system labels (such as .done). In those cases, they will appear localized.

Note: The exception to that rule is the Profile editor with oauth view. The Done button here is provided by the SDK, and should be localized.

@wpmobilebot
Copy link

Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1266
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commitd5607b2
App Center BuildGravatar SDK Demo - SwiftUI #137
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link

Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1266
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commitd5607b2
App Center BuildGravatar SDK Demo - UIKit #138
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@andrewdmontgomery
Copy link
Contributor Author

@etoledom I updated the description to limit the required testing. It just needs to pass CI.

Before we release, we'll want to QA the layouts, etc. But this PR is just to merge in the localizations. The QA should be handled separately.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I noticed we are missing the image source text translations, but they seems to be correctly localized on trunk.

CleanShot 2024-09-19 at 21 58 02@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants