Bump target&compile SDK to 35 in the demo app #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
commented
Feb 13, 2025
Comment on lines
-81
to
-86
|
|
||
| <!-- Lib activities --> | ||
| <activity | ||
| android:name="com.yalantis.ucrop.UCropActivity" | ||
| android:theme="@style/Theme.AppCompat" /> | ||
|
|
There was a problem hiding this comment.
This is not needed, so removing to clean things up.
| @@ -59,7 +58,6 @@ fun GravatarDemoAppTheme( | |||
| if (!view.isInEditMode) { | |||
| SideEffect { | |||
| val window = (view.context as Activity).window | |||
| window.statusBarColor = colorScheme.primary.toArgb() | |||
There was a problem hiding this comment.
Deprecated.
Comment on lines
-154
to
+152
| Column(modifier = Modifier.fillMaxSize()) { | ||
| Column(modifier = modifier.fillMaxSize()) { |
There was a problem hiding this comment.
I noticed this didn't work well after switching to 35. We should always pass the modifier to the Top level composable, not its children.
AdamGrzybkowski
force-pushed
the
adam/bump_target_SDK
branch
from
299ee3b to
35d9810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should help us catch issues like the one in the uCrop with edge-to-edge enforcement.
Testing Steps
Build the demo app and test it.