QuickEditor: Update the Avatar's menu UI #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
Enhance
AdamGrzybkowski
force-pushed
the
adam/556_rating_item_label
branch
from
4791664 to
f6528b6
Compare
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
mlumeau
reviewed
Jan 27, 2025
| @@ -25,50 +25,61 @@ internal fun AvatarMoreOptionsPickerPopup( | |||
| onDismissRequest: () -> Unit, | |||
| onAvatarOptionClicked: (AvatarOption) -> Unit, | |||
| ) { | |||
| val altTextItemLabel = stringResource( | |||
There was a problem hiding this comment.
Why altTextItemLabel? Shouldn't it be named ratingItemLabel?
There was a problem hiding this comment.
oh my... yes... Thanks!
AdamGrzybkowski
force-pushed
the
adam/556_rating_item_label
branch
from
9e08e3b to
a3ca960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
Description
This PR modifies the Avatar's menu by:
Change ratingtoRating: {current}Testing Steps
...button to open the Avatar's menu