Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer string into a translation file & add Ukrainian (uk_ua) translations #152

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

SuperNeon4ik
Copy link

@SuperNeon4ik SuperNeon4ik commented Sep 16, 2024

At the start I wanted to add Ukrainian translations, but noticed some strings were hard-coded in & some translation keys weren't even used, so I also decided to "fix it up a bit ™️ "

This PR:

  • Uses unused, but localized strings like text.autoconfig.islandutils.category.music & text.autoconfig.islandutils.category.cosmetics, instead of hard-coded literals
  • Adds new translation keys like islandutils.message.core.updateAvailable or islandutils.message.friends.thisLobby, that gives an ability to localize more than just the config screen.
  • Adds Ukrainian (uk_ua) translations of the strings (including the ones I added)

Open to feedback! Thank you!

@SuperNeon4ik SuperNeon4ik marked this pull request as ready for review September 17, 2024 20:11
@AsoDesu
Copy link
Owner

AsoDesu commented Oct 6, 2024

hello, pls can you resolve your merge conflicts, because i don't think i can push to your main branch

(in future, please don't open pull requests against your main branch)

@SuperNeon4ik
Copy link
Author

Done! Thank you for the advice!

@AsoDesu
Copy link
Owner

AsoDesu commented Dec 19, 2024

heya, sorry it's been a while lol

since there's been a ton of changes made to IslandUtils since this PR opening, could you resolve the new conflicts created from 1.7.0, then i'll be able to merge this and #149 in :P

@SuperNeon4ik
Copy link
Author

SuperNeon4ik commented Dec 20, 2024

hi! i'm done with catching up with 1.7.0.
could you, please, add a "text.autoconfig.islandutils.option.showFishingUpgradeIcon.@Tooltip translation for English, so I can translate it based on that. i haven't played mcci for a while, so it would be better if you added the string so I could base my translation on yours, so not to guess how the setting actually works.
after that the pr is ready to be merged

@thehamish555
Copy link

Just to comment on this, while working on backporting to 1.21, I added the tool tip with the string "Shows an upgrade icon next to upgradable Fishing Perks". If there needs to be consistency across versions once aso sets up a branch for me to do a PR to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants