-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer string into a translation file & add Ukrainian (uk_ua) translations #152
base: main
Are you sure you want to change the base?
Conversation
… with default font if unsupported chars present in localized string
hello, pls can you resolve your merge conflicts, because i don't think i can push to your main branch (in future, please don't open pull requests against your main branch) |
Done! Thank you for the advice! |
heya, sorry it's been a while lol since there's been a ton of changes made to IslandUtils since this PR opening, could you resolve the new conflicts created from 1.7.0, then i'll be able to merge this and #149 in :P |
hi! i'm done with catching up with 1.7.0. |
Just to comment on this, while working on backporting to 1.21, I added the tool tip with the string "Shows an upgrade icon next to upgradable Fishing Perks". If there needs to be consistency across versions once aso sets up a branch for me to do a PR to |
At the start I wanted to add Ukrainian translations, but noticed some strings were hard-coded in & some translation keys weren't even used, so I also decided to "fix it up a bit ™️ "
This PR:
text.autoconfig.islandutils.category.music
&text.autoconfig.islandutils.category.cosmetics
, instead of hard-coded literalsislandutils.message.core.updateAvailable
orislandutils.message.friends.thisLobby
, that gives an ability to localize more than just the config screen.Open to feedback! Thank you!