Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document interactive development of mavproxy #6371

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Nov 6, 2024

Purpose

Existing Workflow

image

New Workflow

Now, when you change code, it updates when you just kill mavproxy and run it again.

image

@Ryanf55 Ryanf55 marked this pull request as ready for review November 6, 2024 02:46
@Ryanf55 Ryanf55 marked this pull request as draft November 6, 2024 03:12
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a user ordinarily be in the ArduPilot venv here? It seems you're creating a new venv as part of these instructions...

mavproxy/source/docs/development/mavdevenvlinux.rst Outdated Show resolved Hide resolved
mavproxy/source/docs/development/mavdevenvlinux.rst Outdated Show resolved Hide resolved
* Use a venv and develop mode from setup.py

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 6, 2024

Wouldn't a user ordinarily be in the ArduPilot venv here? It seems you're creating a new venv as part of these instructions...

These instructions are for an isolated env. If the instructions are making an assumption you use the ardupilot rep's venv, then maybe it's worth adding that as a prerequisite. I've found it's not required to share the same environment for both repos.

Also, I saw that MAVProxy would be installed twice.
https://github.com/ArduPilot/ardupilot/blob/c0ee3b22163da1b77fcc7362aa6e0e3a8c6a9f8d/Tools/environment_install/install-prereqs-ubuntu.sh#L166

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 8, 2024

How are we supposed to install the wsproto dependency of pymavlink?

https://github.com/ArduPilot/pymavlink/pull/967/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552R10

  • ardupilot/ools/scripts/install-prereqs-ubuntu.sh doesn't have it
  • The setup.py file of pymavlink doesn't have it, only the requirements.txt
  • We don't ever tell devs to install pymavlink's requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants