Adjust max and min battery voltage suggestions to take into account different battery chemistries #6036
Conversation
…ifferent battery chemistries
| @@ -25,8 +25,8 @@ There are 3 common causes of a non-linear thrust curve. | |||
| Start with setting up the voltage range to cope with voltage sag. | |||
| Parameters used to linearise your motor thrust curve. | |||
|
|
|||
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>`: 4.2v x No. Cells | |||
| - :ref:`MOT_BAT_VOLT_MIN <MOT_BAT_VOLT_MIN>`: 3.3v x No. Cells | |||
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>` should be set to the maximum voltage of your batteries, e.g. 4.2v x No. Cells for standard LiPos. | |||
There was a problem hiding this comment.
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>` should be set to the maximum voltage of your batteries, e.g. 4.2v x No. Cells for standard LiPos. | |
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>` should be set to the maximum voltage of your batteries, e.g. 4.2v x No. Cells for standard LiPos, or as appropriate if using a different battery type . |
There was a problem hiding this comment.
Putting the e.g. was meant to mean the 4.2v is just an example. I've already got "of your batteries" so I'm not sure we need the extra bit as well?
Or should we change the "e.g." to "i.e.", so it makes at least a bit more sense?
There was a problem hiding this comment.
eg is the correct term....."for the sake of example" in latin....ie is incorrect "in other words (id est....that is)"
There was a problem hiding this comment.
I do know the difference between eg and ie, actually...
In fact, I was thinking precisely that "that is" would fit better than "for example".
If we're giving just one example - like just mentioning LiPos and nothing else as my original PR had, then "eg" would make sense.
But "4.2v x No. Cells for standard LiPos, or as appropriate if using a different battery type" is effectively all possible options, therefore "for example" doesn't make sense anymore and "that is" makes more sense.
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>`: 4.2v x No. Cells | ||
| - :ref:`MOT_BAT_VOLT_MIN <MOT_BAT_VOLT_MIN>`: 3.3v x No. Cells | ||
| - :ref:`MOT_BAT_VOLT_MAX <MOT_BAT_VOLT_MAX>` should be set to the maximum voltage of your batteries, e.g. 4.2v x No. Cells for standard LiPos. | ||
| - :ref:`MOT_BAT_VOLT_MIN <MOT_BAT_VOLT_MIN>` should be set to the minumum voltage of your batteries, e.g. 3.3v x No. Cells for standard LiPos. |
There was a problem hiding this comment.
| - :ref:`MOT_BAT_VOLT_MIN <MOT_BAT_VOLT_MIN>` should be set to the minumum voltage of your batteries, e.g. 3.3v x No. Cells for standard LiPos. | |
| - :ref:`MOT_BAT_VOLT_MIN <MOT_BAT_VOLT_MIN>` should be set to the minumum voltage of your batteries, e.g. 3.3v x No. Cells for standard LiPos, or as appropriate if using a different battery type . |
There was a problem hiding this comment.
See comment on the other one.
|
I continue to disagree...examples of a statement use eg..restating the statement in simpler terms uses ie |
The 4.2v and 3.3v numbers apply to standard LiPos.
They would not be correct for a LiHV battery or a Liion battery, for example.
Not sure if we want to add the numbers for other chemistries, or just let the user look it up themselves?