Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker multi-fs, chunker update and documentation update #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomGlass
Copy link

@TomGlass TomGlass commented Oct 2, 2020

Docker will now support multiple file systems
Chunker now supports touch FINISH to force into packing queue before minimum megawarc size is hit
Documentation refresh

echo "Current archive is full, moving to ${timestamp}_${uuid}."
mv "${CHUNKER_WORKING_DIR}/current" "${PACKING_QUEUE_DIR}/${timestamp}_${uuid}"
cur_size=0
rm $CHUNKER_WORKING_DIR/FINISH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not escaped correctly

@@ -7,7 +7,17 @@
exit 1
}

mkdir -p /data/incoming /data/chunker-work /data/packing-queue /data/packer-work-in /data/packer-work-out /data/upload-queue /data/uploader-work
if [ -d "/data2" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use test instead of [] shorthand form

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like having /data and /data2 (optional). If we're going to do this, I would prefer an explicit /fs1 and /fs2 (even if in most cases they will point to the same place. Also reduces confusion as other parts of the factory refer to fs1 and fs2 explicitly)

@@ -27,6 +27,16 @@ mkdir -p "${PACKING_QUEUE_DIR}" || exit 1
mkdir -p "${CHUNKER_WORKING_DIR}/current" || exit 1
cur_size=$( du -B1 -s "${CHUNKER_WORKING_DIR}/current" | grep -oE "^[0-9]+" )

if [ -f "$CHUNKER_WORKING_DIR/FINISH" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ${name} instead of $name and use test instead of [] shorthand form

Copy link
Contributor

@km09 km09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out I had some pending comments from a while back. Here they are.

DISK_LIMIT=75 - Limit in percent the target sets rsync connections to -1 (no new connections accepted)
DISK_HARD_LIMIT=90 - Limit in percent the target kills rsync to kill any existing connections
#### target-uploader
LOAD_BALANCER=s3-lb0 - Define loadbalancer you wish to connect to s3-lb1.us.archive.org becomes s3-lb1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the times I'd suggest not documenting a feature. IA doesn't like this, we shouldn't be using this, but was added for convenience for large projects.

@@ -7,7 +7,17 @@
exit 1
}

mkdir -p /data/incoming /data/chunker-work /data/packing-queue /data/packer-work-in /data/packer-work-out /data/upload-queue /data/uploader-work
if [ -d "/data2" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like having /data and /data2 (optional). If we're going to do this, I would prefer an explicit /fs1 and /fs2 (even if in most cases they will point to the same place. Also reduces confusion as other parts of the factory refer to fs1 and fs2 explicitly)

Filesystems 1 and 2 do not have to be the same.

### Running dual filesystems with docker
Overall running dual FS with docker is very simple and easily done. The only container that requires access to both file systems is the packer. To make this simple inside the CT filesystem 1 (fs1) is mounted at /data and fs2 is mounted at /data2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ct -> container

FILE_PREFIX="PROJECT_"
IA_AUTH="no:thanks"
MEGABYTES_PER_CHUNK="$((25*1024))"
ZST_DICTIONARY_API="http://trackerproxy.archiveteam.org:25654/dictionary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge issue, but we need to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants