-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Updating UI #3574
base: main
Are you sure you want to change the base?
fix:Updating UI #3574
Conversation
To me it seems it's still preferential to the top, can we make it centered? |
yes! will change it then |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3574 +/- ##
==========================================
- Coverage 69.61% 67.71% -1.90%
==========================================
Files 502 529 +27
Lines 23253 24704 +1451
==========================================
+ Hits 16187 16729 +542
- Misses 7066 7975 +909
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Adding vertical padding, that I can get behind. But why alter the horizontal padding as well? Looking at the code, it seems like the max line argument is 3 here. I suggest instead that you also remove the constraints altogether in FlowyTextField and set isDense to true. |
Changes Made: Updated the TextField widget behavior to allow for the input of multiple lines of text. Benefits: Enhances user experience by accommodating longer or multiline inputs without sacrificing visibility or usability. |
I don't know where the 13 symmetrical vertical padding comes from but looks good to me |
Added vertical padding because the text was appearing too close to the top.
Before:
After:
In this commit, I adjusted the content padding to include both horizontal and vertical padding in order to improve the visual appearance. The text was previously too close to the top, which could lead to readability issues. This change enhances the overall user experience by providing better spacing.
Screenshots have been included for visual comparison between the original and modified layouts.