Add modernbert-embed-large #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @laulauland. Thanks for contributing. Could you please also add the model to the README.md? |
|
added! |
|
Thanks. LGTM. |
|
added the sample embeddings values and a separate test for modern bert |
Anush008
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks @laulauland. I believe the CI failure is unrelated to the change.
Also apologies for the delay. I have been OOO.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
# [4.5.0](v4.4.0...v4.5.0) (2025-02-18) ### Features * Add modernbert-embed-large ([#146](#146)) ([8184799](8184799)) ## [4.5.0](v4.4.0...v4.5.0) (2025-02-18) ### 🍕 Features * Add modernbert-embed-large ([#146](#146)) ([8184799](8184799)) ### 🧑💻 Code Refactoring * organize the import and export of SparseModel ([#141](#141)) ([2f982f1](2f982f1)) ### 🧹 Chores * Bump hf-hub to 0.4.1 ([#142](#142)) ([b5911b4](b5911b4))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ModernBERT-embed-large to the roster of available models.
ModernBERT is an encoder-only base model that was released at the end of last year. The model itself cannot be used for embeddings but a finetuned
-embed-*version can be.