-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependency blosc to blosc2 #86
Updated dependency blosc to blosc2 #86
Conversation
My man, it looks like this allows us to save objects over 2^32 bytes also. Huge improvement. Thanks. |
@franzhuettinger tests failed, it looks like blosc wasn't updated in utils. |
I forgot to update the github/workflow file. Please try again. |
@franzhuettinger it looks like it still isn't updated in utils. |
I do not see the problem at the moment but it's late today. I'll check it tomorrow. |
In some places blosc was still used instead of blosc2. I have found these places and repaired them. I hope to have found all the places now. |
@franzhuettinger hmmm it looks like the blosc2 API changed somewhat, there is no |
I had some trouble setting up pytest on my local machine but in between I found the problem. Next commit will be tested properly. |
|
Still there seems to be a problem with python 3.7 and 3.8. Haven't seen this problem on my machine. Will try to find the problem tomorrow. |
On my system, I was able to successfully complete the tests with Python 3.12, 3.9 and 3.8. I had no success with Python 3.7. Blosc2 requires at least Python 3.10 but up to version 3.8 it still seems to work without any problems. If you want to maintain support for Python 3.7, then we will probably not be able to solve the problem easily. My recommendation would be to increase the minimum requirement to 3.9. |
That's all fine with me. I've noticed many new package versions are removing support for 3.7. |
I have only updated the dependency to blosc and changed it from blosc to blosc2. The reason for this is that blosc is no longer compatible with latest libraries and also some changes regarding NumPy were not up to date. Please feel free to add these changes to the project.