Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/net: enable multicast addresses if IPv6 is enabled #716

Merged
merged 1 commit into from
Nov 25, 2024
Merged

lib/net: enable multicast addresses if IPv6 is enabled #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions lib/net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,23 +1690,6 @@ create_bond(struct gatekeeper_if *iface)
}
}

if (__lacp_enabled(iface)) {
/*
* If LACP is enabled, enable multicast addresses.
* Otherwise, rx_burst_8023ad() of DPDK's bonding driver
* (see rte_eth_bond_pmd.c) is going to discard
* multicast Ethernet packets such as ARP and
* ND packets.
*/
ret = rte_eth_allmulticast_enable(iface->id);
if (unlikely(ret < 0)) {
G_LOG(ERR, "%s(%s): cannot enable multicast on bond device (errno=%i): %s\n",
__func__, iface->name,
-ret, rte_strerror(-ret));
goto close_bond;
}
}

/* Add members to bond. */
for (i = 0; i < iface->num_ports; i++) {
ret = rte_eth_bond_member_add(iface->id, iface->ports[i]);
Expand Down Expand Up @@ -2021,6 +2004,25 @@ init_iface(struct gatekeeper_if *iface)
goto free_ports;
}

/*
* IPv6's protocol ND requires multicast. Therefore,
* if IPv6 is enabled, enable multicast addresses.
*
* Most DPDK's drivers have multicast enabled by default,
* but a few drivers have it disabled by default.
* Drivers known to have multicast disabled by default are
* the bonding driver when LACP is being used and the i40e driver.
*/
if (ipv6_if_configured(iface)) {
ret = rte_eth_allmulticast_enable(iface->id);
if (unlikely(ret < 0)) {
G_LOG(ERR, "%s(%s): cannot enable multicast (errno=%i): %s\n",
__func__, iface->name,
-ret, rte_strerror(-ret));
goto close_ports;
}
}

/* Make sure the interface supports hardware offloads. */
ret = check_if_offloads(iface, &port_conf);
if (unlikely(ret < 0)) {
Expand Down