gatekeeper: rewrite initialization of network interfaces

gk/main.c

@@ -2541,9 +2541,13 @@ gk_stage1(void *arg)
 
 	num_mbuf = calculate_mempool_config_para("gk", gk_conf->net,
 		gk_conf->front_max_pkt_burst + gk_conf->back_max_pkt_burst +
+		/*
+		 * One cannot divide the sum below per gk_conf->num_lcores
+		 * because, though unlikely, it might happen that
+		 * all packets go to a single instance.
+		 */
 		(gk_conf->net->front.total_pkt_burst +
-		gk_conf->net->back.total_pkt_burst + gk_conf->num_lcores - 1) /
-		gk_conf->num_lcores);
+		gk_conf->net->back.total_pkt_burst));
 
 	sol_conf = gk_conf->sol_conf;
 	for (i = 0; i < gk_conf->num_lcores; i++) {

gt/main.c

@@ -2067,8 +2067,12 @@ init_gt_instances(struct gt_config *gt_conf)
 		gt_conf->net, gt_conf->max_pkt_burst +
 		gt_conf->frag_max_entries + gt_conf->max_pkt_burst +
 		gt_conf->max_ggu_notify_pkts +
-		(gt_conf->net->front.total_pkt_burst +
-		gt_conf->num_lcores - 1) / gt_conf->num_lcores);
+		/*
+		 * One cannot divide the sum below per gt_conf->num_lcores
+		 * because, though unlikely, it might happen that
+		 * all packets go to a single instance.
+		 */
+		gt_conf->net->front.total_pkt_burst);
 
 	/* Set up queue identifiers now for RSS, before instances start. */
 	for (i = 0; i < gt_conf->num_lcores; i++) {

include/gatekeeper_log_ratelimit.h

@@ -74,7 +74,17 @@ void log_ratelimit_state_init(unsigned int lcore_id, uint32_t interval,
  *   - 0: Success.
  *   - Negative on error.
  */
-int rte_log_ratelimit(uint32_t level, uint32_t logtype, const char *format, ...)
+int gatekeeper_log_ratelimit(uint32_t level, uint32_t logtype,
+	const char *format, ...)
+#ifdef __GNUC__
+#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2))
+	__attribute__((cold))
+#endif
+#endif
+	__attribute__((format(printf, 3, 4)));
+
+int gatekeeper_log_main(uint32_t level, uint32_t logtype,
+	const char *format, ...)
 #ifdef __GNUC__
 #if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2))
 	__attribute__((cold))
@@ -86,9 +96,6 @@ int rte_log_ratelimit(uint32_t level, uint32_t logtype, const char *format, ...)
 int set_log_level_per_block(const char *block_name, uint32_t log_level);
 int set_log_level_per_lcore(unsigned int lcore_id, uint32_t log_level);
 
-/* Get the block name for the corresponding lcore. */
-const char *get_block_name(unsigned int lcore_id);
-
 struct log_ratelimit_state {
 	uint64_t       interval_cycles;
 	uint32_t       burst;
@@ -97,12 +104,27 @@ struct log_ratelimit_state {
 	uint64_t       end;
 	rte_atomic32_t log_level;
 	char           block_name[16];
-	char           str_date_time[32];
-	uint64_t       update_time_at;
 } __rte_cache_aligned;
 
-/* Only use these variables in file lib/log_ratelimit.c and in macro G_LOG(). */
+struct log_thread_time {
+	char     str_date_time[32];
+	uint64_t update_time_at;
+};
+
+/*
+ * Only use these variables in file lib/log_ratelimit.c and in macros
+ * G_LOG() and MAIN_LOG().
+ */
+RTE_DECLARE_PER_LCORE(struct log_thread_time, _log_thread_time);
 extern struct log_ratelimit_state log_ratelimit_states[RTE_MAX_LCORE];
 extern bool log_ratelimit_enabled;
 
+/* Get the block name for the corresponding lcore. */
+static inline const char *get_block_name(unsigned int lcore_id)
+{
+	return lcore_id < RTE_MAX_LCORE
+		? log_ratelimit_states[lcore_id].block_name
+		: "NO-lcore";
+}
+
 #endif /* _GATEKEEPER_LOG_RATELIMIT_H_ */

include/gatekeeper_main.h

@@ -35,25 +35,38 @@
 
 #define BLOCK_LOGTYPE RTE_LOGTYPE_USER1
 #define G_LOG_PREFIX "%s/%u %s %s "
+#define G_LOG_MAIN "Main"
 
 #define G_LOG(level, fmt, ...)						\
 	do {								\
 		unsigned int __g_log_lcore_id = rte_lcore_id();		\
-		const struct log_ratelimit_state *__g_log_lrs =		\
-			&log_ratelimit_states[__g_log_lcore_id];	\
-		rte_log_ratelimit(RTE_LOG_ ## level, BLOCK_LOGTYPE,	\
-			G_LOG_PREFIX fmt,				\
+		gatekeeper_log_ratelimit(RTE_LOG_ ## level,		\
+			BLOCK_LOGTYPE,	G_LOG_PREFIX fmt,		\
 			likely(log_ratelimit_enabled)			\
-				? __g_log_lrs->block_name		\
-				: "Main",				\
+				? log_ratelimit_states[__g_log_lcore_id]\
+					.block_name			\
+				: G_LOG_MAIN,				\
 			__g_log_lcore_id,				\
-			__g_log_lrs->str_date_time,			\
+			RTE_PER_LCORE(_log_thread_time).str_date_time,	\
 			#level						\
 			__VA_OPT__(,) __VA_ARGS__);			\
 	} while (0)
 
 #define G_LOG_CHECK(level) check_log_allowed(RTE_LOG_ ## level)
 
+/*
+ * This macro should only be called in contexts other than logical cores
+ * because it is independent of functional blocks and is not rate limited.
+ *
+ * From logical cores, call G_LOG().
+ */
+#define MAIN_LOG(level, fmt, ...)					\
+	gatekeeper_log_main(RTE_LOG_ ## level, BLOCK_LOGTYPE,		\
+		G_LOG_PREFIX fmt, G_LOG_MAIN, rte_gettid(),		\
+		RTE_PER_LCORE(_log_thread_time).str_date_time,		\
+		#level							\
+		__VA_OPT__(,) __VA_ARGS__)
+
 extern volatile int exiting;
 
 #define ONE_SEC_IN_NANO_SEC (1000000000L)

include/gatekeeper_net.h

@@ -430,12 +430,6 @@ struct net_config {
 	 */
 	int                  back_iface_enabled;
 
-	/*
-	 * Number of attempts to wait for Gatekeeper links to
-	 * come up during initialization.
-	 */
-	unsigned int         num_attempts_link_get;
-
 	/*
 	 * The NUMA nodes used in the host. Element i is true
 	 * if NUMA node i is being used; otherwise it is false.
@@ -481,7 +475,7 @@ struct net_config {
 
 /* Call lacp_enabled() instead this function wherever possible. */
 static inline int
-__lacp_enabled(struct gatekeeper_if *iface)
+__lacp_enabled(const struct gatekeeper_if *iface)
 {
 	return	iface->bonding_mode == BONDING_MODE_8023AD;
 }

include/gatekeeper_sol.h

@@ -102,13 +102,6 @@ struct sol_config {
 	/* Maximum number of requests to store in priority queue at once. */
 	unsigned int        pri_req_max_len;
 
-	/*
-	 * Bandwidth limit for the priority queue of requests,
-	 * as a percentage of the capacity of the link. Must
-	 * be > 0 and < 1.
-	 */
-	double              req_bw_rate;
-
 	/* Maximum request enqueue/dequeue size. */
 	unsigned int        enq_burst_size;
 	unsigned int        deq_burst_size;

include/list.h

@@ -41,6 +41,12 @@ INIT_LIST_HEAD(struct list_head *list)
 	list->prev = list;
 }
 
+static inline int
+list_initiated(const struct list_head *head)
+{
+	return head->next != NULL && head->prev != NULL;
+}
+
 /**
  * list_entry - get the struct for this entry
  * @ptr:	the &struct list_head pointer.

lib/log_ratelimit.c

@@ -27,8 +27,8 @@
 #include "gatekeeper_main.h"
 #include "gatekeeper_log_ratelimit.h"
 
+RTE_DEFINE_PER_LCORE(struct log_thread_time, _log_thread_time);
 struct log_ratelimit_state log_ratelimit_states[RTE_MAX_LCORE];
-
 bool log_ratelimit_enabled;
 
 void
@@ -47,16 +47,17 @@ check_log_allowed(uint32_t level)
 #define NO_TIME_STR "NO TIME"
 
 static void
-update_str_date_time(struct log_ratelimit_state *lrs, uint64_t now)
+update_str_date_time(uint64_t now)
 {
+	struct log_thread_time *ttime = &RTE_PER_LCORE(_log_thread_time);
 	struct timespec tp;
 	struct tm *p_tm, time_info;
 	uint64_t diff_ns;
 	int ret;
 
-	RTE_BUILD_BUG_ON(sizeof(NO_TIME_STR) > sizeof(lrs->str_date_time));
+	RTE_BUILD_BUG_ON(sizeof(NO_TIME_STR) > sizeof(ttime->str_date_time));
 
-	if (likely(now < lrs->update_time_at)) {
+	if (likely(now < ttime->update_time_at)) {
 		/* Fast path, that is, high log rate. */
 		return;
 	}
@@ -73,7 +74,7 @@ update_str_date_time(struct log_ratelimit_state *lrs, uint64_t now)
 	if (unlikely(p_tm != &time_info))
 		goto no_time;
 
-	ret = strftime(lrs->str_date_time, sizeof(lrs->str_date_time),
+	ret = strftime(ttime->str_date_time, sizeof(ttime->str_date_time),
 		"%Y-%m-%d %H:%M:%S", &time_info);
 	if (unlikely(ret == 0))
 		goto no_time;
@@ -83,23 +84,25 @@ update_str_date_time(struct log_ratelimit_state *lrs, uint64_t now)
 no_tp:
 	tp.tv_nsec = 0;
 no_time:
-	strcpy(lrs->str_date_time, NO_TIME_STR);
+	strcpy(ttime->str_date_time, NO_TIME_STR);
 next_update:
 	diff_ns = likely(tp.tv_nsec >= 0 && tp.tv_nsec < ONE_SEC_IN_NANO_SEC)
 		? (ONE_SEC_IN_NANO_SEC - tp.tv_nsec)
 		: ONE_SEC_IN_NANO_SEC; /* C library bug! */
-	lrs->update_time_at = now + (typeof(now))round(diff_ns * cycles_per_ns);
+	ttime->update_time_at =
+		now + (typeof(now))round(diff_ns * cycles_per_ns);
 }
 
 static void
 log_ratelimit_reset(struct log_ratelimit_state *lrs, uint64_t now)
 {
 	lrs->printed = 0;
 	if (lrs->suppressed > 0) {
-		update_str_date_time(lrs, now);
+		update_str_date_time(now);
 		rte_log(RTE_LOG_NOTICE, BLOCK_LOGTYPE,
 			G_LOG_PREFIX "%u log entries were suppressed during the last ratelimit interval\n",
-			lrs->block_name, rte_lcore_id(), lrs->str_date_time,
+			lrs->block_name, rte_lcore_id(),
+			RTE_PER_LCORE(_log_thread_time).str_date_time,
 			"NOTICE", lrs->suppressed);
 	}
 	lrs->suppressed = 0;
@@ -111,7 +114,6 @@ log_ratelimit_state_init(unsigned int lcore_id, uint32_t interval,
 	uint32_t burst, uint32_t log_level, const char *block_name)
 {
 	struct log_ratelimit_state *lrs;
-	uint64_t now;
 
 	RTE_VERIFY(lcore_id < RTE_MAX_LCORE);
 
@@ -124,10 +126,7 @@ log_ratelimit_state_init(unsigned int lcore_id, uint32_t interval,
 	lrs->suppressed = 0;
 	rte_atomic32_set(&lrs->log_level, log_level);
 	strcpy(lrs->block_name, block_name);
-	lrs->str_date_time[0] = '\0';
-	now = rte_rdtsc();
-	lrs->update_time_at = now;
-	log_ratelimit_reset(lrs, now);
+	log_ratelimit_reset(lrs, rte_rdtsc());
 }
 
 /*
@@ -162,7 +161,8 @@ log_ratelimit_allow(struct log_ratelimit_state *lrs, uint64_t now)
 }
 
 int
-rte_log_ratelimit(uint32_t level, uint32_t logtype, const char *format, ...)
+gatekeeper_log_ratelimit(uint32_t level, uint32_t logtype,
+	const char *format, ...)
 {
 	uint64_t now = rte_rdtsc(); /* Freeze current time. */
 	struct log_ratelimit_state *lrs = &log_ratelimit_states[rte_lcore_id()];
@@ -183,7 +183,20 @@ rte_log_ratelimit(uint32_t level, uint32_t logtype, const char *format, ...)
 	return 0;
 
 log:
-	update_str_date_time(lrs, now);
+	update_str_date_time(now);
+	va_start(ap, format);
+	ret = rte_vlog(level, logtype, format, ap);
+	va_end(ap);
+	return ret;
+}
+
+int
+gatekeeper_log_main(uint32_t level, uint32_t logtype, const char *format, ...)
+{
+	va_list ap;
+	int ret;
+
+	update_str_date_time(rte_rdtsc());
 	va_start(ap, format);
 	ret = rte_vlog(level, logtype, format, ap);
 	va_end(ap);
@@ -214,12 +227,3 @@ set_log_level_per_lcore(unsigned int lcore_id, uint32_t log_level)
 	rte_atomic32_set(&log_ratelimit_states[lcore_id].log_level, log_level);
 	return 0;
 }
-
-const char *
-get_block_name(unsigned int lcore_id)
-{
-	if (lcore_id >= RTE_MAX_LCORE) {
-		return "invalid lcore";
-	}
-	return log_ratelimit_states[lcore_id].block_name;
-}