fib: review lock requirements #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltraMayor
added
the
Operational demand
new_route() and del_route() were not safely handling the lock of the RIB.
Replace lpm_lookup_ipv4() and lpm_lookup_ipv6() with rib_lookup(). lpm_lookup_ipv4() and lpm_lookup_ipv6() are now only used to look up destination addresses in packets. This prepares the code to eventually support SmartNICs that can offload LPM lookups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code around the FIB has tried to do some of the work related to adding and removing entries without holding a lock. The intention was to be faster, but the savings are small since there are way more readers than writers. Moreover, the risk of crashing Gatekeeper is too high. This pull request conservatively protects this code by acquiring the lock before it.
In addition, all FIB lookups that are not for incoming packets are rewritten to use the Routing Information Base added in pull request #594. This prepares Gatekeeper to eventually support NICs that can offload LPM lookups.