Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message-level feedback with thumbs up/down buttons #7508

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Mar 25, 2025

This PR adds thumbs up and thumbs down buttons to each assistant message in the chat interface.

Changes:

  • Added a new UserFeedbackAction type for sending feedback events
  • Updated the Message type to include a feedback property
  • Created a new MessageFeedback component to display thumbs up/down buttons
  • Modified the trajectory-level feedback to use the same mechanism
  • Removed the old feedback modal in favor of direct WebSocket events
  • Added toast notifications for feedback confirmation

Feedback can now be provided at both the message level and trajectory level, with consistent handling for both.

Testing:

  • Fixed all TypeScript errors and linting issues
  • All tests are passing
  • Verified the build process completes successfully

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:10cdf88-nikolaik   --name openhands-app-10cdf88   docker.all-hands.dev/all-hands-ai/openhands:10cdf88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants