Main #34

Salnikova-Lida · 2025-01-16T18:40:49Z

tasks 1, 2, 4

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 28. Check the log or trigger a new build to see more.

task_01/src/test.cpp

task_02/src/test.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 43. Check the log or trigger a new build to see more.

task_01/src/test.cpp

task_02/src/test.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 43. Check the log or trigger a new build to see more.

task_01/src/test.cpp

task_02/src/test.cpp

Salnikova-Lida · 2025-01-16T21:49:28Z

I've done tasks 1, 2, 4 and 5 in this pull request

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 43. Check the log or trigger a new build to see more.

task_01/src/test.cpp

task_02/src/test.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 43. Check the log or trigger a new build to see more.

task_01/src/test.cpp

github-actions · 2025-01-16T22:07:24Z

task_02/src/test.cpp

+  std::vector<int> weak_vertexes = CuttingVertex(data);
+  std::vector<std::pair<int, int>> ans_edge = {{2, 1}, {2, 3}, {3, 4}, {4, 5},
+                                               {5, 6}, {6, 7}, {7, 8}};
+  std::vector<int> ans_vert = {1, 2, 3, 4, 5, 6, 7};


warning: variable 'ans_vert' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> ans_vert = {1, 2, 3, 4, 5, 6, 7};

std::vector<int> const ans_vert = {1, 2, 3, 4, 5, 6, 7};

task_02/src/test.cpp

LostPointer

не все задания и в первом тестов не хватает(

task_01/src/test.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 52. Check the log or trigger a new build to see more.

github-actions · 2025-01-16T23:10:42Z

task_01/src/test.cpp

+std::vector<int> TopologicalSort(std::vector<std::vector<int>> &data) {
+  int lenth = data.size();
+  std::vector<int> status(lenth, 0);
+  std::vector<int> top_order;


warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]

{ ^

github-actions · 2025-01-16T23:10:42Z

task_01/src/test.cpp

+std::vector<int> TopologicalSort(std::vector<std::vector<int>> &data) {
+  int lenth = data.size();
+  std::vector<int> status(lenth, 0);
+  std::vector<int> top_order;


warning: variable 'lenth' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> top_order;

{const

github-actions · 2025-01-16T23:10:42Z

task_01/src/test.cpp

+  std::vector<std::vector<int>> data({{1}, {2, 3}, {3, 0}, {}});
+  try {
+    std::vector<int> top_order = TopologicalSort(data);
+  } catch (std::runtime_error) {


warning: variable 'top_order' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

} catch (std::runtime_error) {

);const

github-actions · 2025-01-16T23:10:42Z

task_01/src/test.cpp

+  } catch (std::runtime_error) {
+    error = true;
+  }
+  ASSERT_EQ(error, true);  // Stack []


warning: catch handler catches by value; should catch by reference instead [misc-throw-by-value-catch-by-reference]

Sort(data); ^

github-actions · 2025-01-16T23:10:42Z

task_01/src/test.cpp

+      {{}, {4, 6}, {7}, {7, 4}, {5}, {}, {2}, {0, 6, 5}});
+  try {
+    std::vector<int> top_order = TopologicalSort(data);
+  } catch (std::runtime_error) {


warning: variable 'top_order' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

} catch (std::runtime_error) {

);const

github-actions · 2025-01-16T23:10:43Z

task_02/src/test.cpp

+  std::vector<int> weak_vertexes = CuttingVertex(data);
+  std::vector<std::pair<int, int>> ans_edge = {{2, 1}, {2, 3}, {3, 4}, {4, 5},
+                                               {5, 6}, {6, 7}, {7, 8}};
+  std::vector<int> ans_vert = {1, 2, 3, 4, 5, 6, 7};


warning: variable 'ans_vert' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> ans_vert = {1, 2, 3, 4, 5, 6, 7};

std::vector<int> const ans_vert = {1, 2, 3, 4, 5, 6, 7};

github-actions · 2025-01-16T23:10:43Z

task_02/src/test.cpp

+                                      {6, 4},
+                                      {4}});
+  std::vector<std::pair<int, int>> weak_edges = CuttingEdge(data);
+  std::vector<int> weak_vertexes = CuttingVertex(data);


warning: variable 'weak_vertexes' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> weak_vertexes = CuttingVertex(data);

std::vector<int> const weak_vertexes = CuttingVertex(data);

github-actions · 2025-01-16T23:10:43Z

task_02/src/test.cpp

+  std::vector<int> weak_vertexes = CuttingVertex(data);
+  std::vector<std::pair<int, int>> ans_edge = {
+      {2, 1}, {4, 9}, {3, 5}, {3, 7}, {4, 3}, {8, 6}, {4, 8}, {2, 4}, {0, 2}};
+  std::vector<int> ans_vert = {2, 3, 4, 8};


warning: variable 'ans_vert' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> ans_vert = {2, 3, 4, 8};

std::vector<int> const ans_vert = {2, 3, 4, 8};

github-actions · 2025-01-16T23:10:43Z

task_02/src/test.cpp

+  std::vector<std::vector<int>> data(
+      {{1, 8}, {0, 2}, {1, 3}, {2, 4}, {3, 5}, {4, 6}, {5, 7}, {6, 8}, {7, 0}});
+  std::vector<std::pair<int, int>> weak_edges = CuttingEdge(data);
+  std::vector<int> weak_vertexes = CuttingVertex(data);


warning: variable 'weak_vertexes' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> weak_vertexes = CuttingVertex(data);

std::vector<int> const weak_vertexes = CuttingVertex(data);

github-actions · 2025-01-16T23:10:44Z

task_02/src/test.cpp

+  std::vector<std::pair<int, int>> weak_edges = CuttingEdge(data);
+  std::vector<int> weak_vertexes = CuttingVertex(data);
+  std::vector<std::pair<int, int>> ans_edge = {};
+  std::vector<int> ans_vert = {};


warning: variable 'ans_vert' of type 'std::vector' can be declared 'const' [misc-const-correctness]

Suggested change

std::vector<int> ans_vert = {};

std::vector<int> const ans_vert = {};

Salnikova-Lida added 6 commits January 15, 2025 09:10

first task

cf49f9f

beautify test1

5195c05

task 4

d208a9d

task 2 with tests

1329430

beautify and some comments

316edf4

Merge branch 'main' into main

d0dbccd

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Salnikova-Lida added 2 commits January 16, 2025 21:31

task 5 with test

261775d

clang format

bfd4579

github-actions bot reviewed Jan 16, 2025

View reviewed changes

trying clang 2

a90ae72

github-actions bot reviewed Jan 16, 2025

View reviewed changes

trying clang 3

95efae7

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Salnikova-Lida added 2 commits January 16, 2025 22:04

beautify cases

36df25e

cases

8e78b10

github-actions bot reviewed Jan 16, 2025

View reviewed changes

AlgorithmsDafeMipt2024 deleted a comment from github-actions bot Jan 16, 2025

LostPointer reviewed Jan 16, 2025

View reviewed changes

task_01/src/test.cpp Show resolved Hide resolved

task 6

df3a6d0

github-actions bot reviewed Jan 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main #34

Main #34

Salnikova-Lida commented Jan 16, 2025

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Salnikova-Lida commented Jan 16, 2025

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Jan 16, 2025

LostPointer left a comment

github-actions bot left a comment

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

github-actions bot Jan 16, 2025

	std::vector<int> ans_vert = {1, 2, 3, 4, 5, 6, 7};
	std::vector<int> const ans_vert = {1, 2, 3, 4, 5, 6, 7};

	std::vector<int> weak_vertexes = CuttingVertex(data);
	std::vector<int> const weak_vertexes = CuttingVertex(data);

	std::vector<int> ans_vert = {2, 3, 4, 8};
	std::vector<int> const ans_vert = {2, 3, 4, 8};

	std::vector<int> ans_vert = {};
	std::vector<int> const ans_vert = {};

Main #34

Are you sure you want to change the base?

Main #34

Conversation

Salnikova-Lida commented Jan 16, 2025

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Salnikova-Lida commented Jan 16, 2025

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

LostPointer left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment

github-actions bot Jan 16, 2025

Choose a reason for hiding this comment