-
Notifications
You must be signed in to change notification settings - Fork 22
Tikhonov_Timofey #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tikhonov_Timofey #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
task_01/src/main.cpp
Outdated
void topologicalSort(vector<vector<int>> &g) | ||
{ | ||
stack<int> Stack; | ||
int V = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]
int V = g.size();
^
task_01/src/main.cpp
Outdated
void topologicalSort(vector<vector<int>> &g) | ||
{ | ||
stack<int> Stack; | ||
int V = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'V' of type 'int' can be declared 'const' [misc-const-correctness]
int V = g.size(); | |
int const V = g.size(); |
task_01/src/main.cpp
Outdated
int main() | ||
{ | ||
vector<vector<int>> g = {{0,0,0,0,0,0},{0,0,0,0,0,0},{0,0,0,1,0,0},{0,1,0,0,0,0},{1,1,0,0,0,0},{1,0,1,0,0,0}}; | ||
int N = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: Value stored to 'N' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
int N = g.size();
^
Additional context
task_01/src/main.cpp:38: Value stored to 'N' during its initialization is never read
int N = g.size();
^
task_01/src/main.cpp
Outdated
int main() | ||
{ | ||
vector<vector<int>> g = {{0,0,0,0,0,0},{0,0,0,0,0,0},{0,0,0,1,0,0},{0,1,0,0,0,0},{1,1,0,0,0,0},{1,0,1,0,0,0}}; | ||
int N = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]
int N = g.size();
^
task_01/src/main.cpp
Outdated
int main() | ||
{ | ||
vector<vector<int>> g = {{0,0,0,0,0,0},{0,0,0,0,0,0},{0,0,0,1,0,0},{0,1,0,0,0,0},{1,1,0,0,0,0},{1,0,1,0,0,0}}; | ||
int N = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'N' of type 'int' can be declared 'const' [misc-const-correctness]
int N = g.size(); | |
int const N = g.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 29. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 31. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 15 out of 38. Check the log or trigger a new build to see more.
тестов нет совсем, все в одном файле нет разбивки по файлам( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лишние бинарники в ПРе
No description provided.