Added iOS storyboard support, including --use-storyboard-singular=true #57
Conversation
john-doherty
commented
Apr 10, 2018
john-doherty
commented
- Merged previous iOS storyboard support, but disabled legacy image generation when in storyboard mode
- Added --use-storyboard-singular=true switch to generate a singular storyboard image which reduces the overall app size
- Updated README to reflect changes
Added support for the new images required for Storyboard mode (required for iPad Pro, iPhone X). Usage: cordova-splash --use-storyboard=true
…storyboard-singular=true
|
Do I have to add any settings to config.xml to use the iOS storyboard? |
|
@AlexDisler when merge this to master branch? |
|
👍 |
|
It would be great to get this merged. I can see there is a conflict but I am unable to resolve it as I don't have write access... Anyone needing this version can install via: npm install -g john-doherty/cordova-splash |
|
Hi @john-doherty. Thanks for this. I have installed your version and it works nicely. But the images generated in Images.xcassets/LaunchStoryboard.imageset seem to be ignored. The images in Images.xcassets/LaunchImage.launchimage are used instead. And in Xcode I see the following warning: "The image set "LaunchStoryboard" has an unassigned child." This turns out to be the generated Default@2x~universal~anyany.png (--use-storyboard-singular=true). So it seems to me that there must be more to getting this to work than I expected. The Contents.json file seems to need updating. And I am not sure what to do in order to fully replace legacy launch images with the storyboard image(s). When I tried simply deleting Images.xcassets/LaunchImage.launchimage the Cordova/Xcode build failed. Thoughts? |
