Skip to content
This repository has been archived by the owner on Oct 19, 2020. It is now read-only.

Fix the productName value when attributes are used #121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

david-spaeth
Copy link

Fix the bad value of productName variable if short attribute has use in name tag
Cordova allow short attribute in name tag. See: https://cordova.apache.org/docs/en/latest/config_ref/#short-name

david-spaeth added 3 commits March 7, 2018 17:30
Fix the bad value of `productName` variable if `short` attribute has use in `name` tag
Cordova allow `short` attribute in `name` tag. See: https://cordova.apache.org/docs/en/latest/config_ref/#short-name
@ivar-tp
Copy link

ivar-tp commented Apr 3, 2018

Was about to create the same pull request. Merging this is much appreciated since using short attribute is a common scenario and at this point returns an object. Also the workaround as suggested here #125 does not work ok in all scenario's since it messes the App's name in some cases.

Also the fix done for android old paths is a good one that prevents manual copying for older setups using latest version of the cordova-icon plugin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants