fix: Avoid SSR memory leak #948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsfj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello 🙋♀️
using the package
v-tooltip@2, I encountered some problems with memory leaks in a server side rendering setup.I tracked down the problems to usage of v-tooltip and its object of default options. I couldn't quite figure out the reason, but I suspect that vue instances are not garbage collected because they are somehow connected to this object.
Anyway, moving the default options to a factory resolves the problem. The default object is not exposed outside the package, so as far as I can tell this shouldn't change any functionalit.
It would be great to see a new version of v-tooltip released even though floating-vue is the successor.
Let me know what you think and if I can help!
Simon