Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should resolve #346.
Using
v-tooltip
in Shadow DOM results in incorrect behavior such as inability of a tooltip to close itself. The reason is in a check in_scheduleHide
method ofTooltip
class that ensures tooltip's node is in the DOM, while not accounting for nodes located in Shadow DOM:Instead, I added a utility function that accounts for Shadow DOM
isInDocument(element)
tosrc/utils.js
and used it in_scheduleHide
.Also, I made it possible to provide a callback to the
container
property, so that the container can be resolved dynamically at the moment the tooltip opens. It is useful as theshadowRoot
's content is not queryable usingdocument.querySelector()
, so providing a selector is not an option in that case.Updated types and README accordingly.
Next, I changed a line in the
Popover.vue
as stated in #346.These are all the changes made to the library, though I also created a couple of components in
docs-src
app undershadow
folder. I included them intoPageHome.vue
while development to reproduce the tooltip's behavior in Shadow DOM, but later commented it out. So in case anything breaks or requires further improvement, the Shadow DOM showcase can easily be set up again.