Merge pull request #164 from dave14305/localnames

Prevent wrong client name in Get_LocalName()
Adamm00 · Feb 17, 2025 · b388084 · b388084 · KamilBednarczykIntel · Feb 20, 2025
2 parents 381d18f + 02fe5db
commit b388084
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/firewall.sh b/firewall.sh
@@ -1243,7 +1243,8 @@ Download_File() {
 }
 
 Get_LocalName() {
-	localname="$(nvram get custom_clientlist | grep -ioE "<.*>$macaddr" | sed -E 's/.*<([^>]+)>[^<]*$/\1/; s/[^a-zA-Z0-9.-]//g')"
+	localname=""
+	if [ -n "$macaddr" ]; then localname="$(nvram get custom_clientlist | grep -ioE "<.*>$macaddr" | sed -E 's/.*<([^>]+)>[^<]*$/\1/; s/[^a-zA-Z0-9.-]//g')"; fi
 	if [ -z "$localname" ]; then localname="$(grep -F "$ipaddr " /var/lib/misc/dnsmasq.leases | awk '{print $4}')"; fi
 	if [ -z "$localname" ] || [ "$localname" = "*" ]; then
 		if [ -n "$macaddr" ]; then