Makes the header reactive #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogin into the website
|
@ErikBjare there is a failing test but I have tested it. It works, not sure what triggered it. |
|
Don't worry about the failing test. I don't think I set it up properly to begin with. |
|
Let me know when you get time to review the changes |
|
@ErikBjare I have more commits... I don't know if I should just keep stacking them on this single pull request or I should wait first. Just let me know 👍 |
|
I'll merge this so you can keep working in new PRs :) |
0xbrayo
added a commit
that referenced
this pull request
Jan 19, 2025
* Makes the header reactive, previously it would not update after you login into the website * Persist auth status between sessions * fix the failing test
0xbrayo
added a commit
that referenced
this pull request
Feb 7, 2025
* Makes the header reactive, previously it would not update after you login into the website * Persist auth status between sessions * fix the failing test
0xbrayo
added a commit
that referenced
this pull request
Feb 7, 2025
* Makes the header reactive, previously it would not update after you login into the website * Persist auth status between sessions * fix the failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header previously would not update after you login. Did some digging and turns it because it's already mounted after the updates. It is not actively watching for changes to the user login state. So I refactored it to be embedded in some of the pages that need an updated state.