updates

[0xbrayo]

🚀	This description was created by Ellipsis for commit ad0a1e3

Summary:

Updated Firestore rules, indexes, Firebase functions, and Vue components for improved authentication and data handling.

Key points:

• Updated README.md to include initial setup instructions.
• Added Firestore indexes in functions/firestore.indexes.json.
• Defined Firestore security rules in functions/firestore.rules.
• Updated functions/package.json to include generate-api-key dependency.
• Implemented Firebase functions in functions/src/index.ts for user creation, deletion, API key management, data upload, and leaderboard updates.
• Added TypeScript interfaces and default categories in functions/src/types.ts.
• Defined Cloud Storage rules in functions/storage.rules.
• Updated src/components/Dashboard.vue and src/components/Leaderboard.vue to include authentication checks.
• Modified src/firebase/data.ts to include query parameters for fetching screen time data.

---

Generated with ❤️ by ellipsis.dev

[github-actions]

Visit the preview URL for this PR (updated for commit ad0a1e3):

https://aw-leaderboard--pr19-master-j9i375pi.web.app

_{(expires Tue, 25 Jun 2024 11:59:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: c41748b80c8db8604c9c431c363ccab703d858c1}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to ad0a1e3 in 1 minute and 26 seconds

More details

• Looked at 610 lines of code in 11 files
• Skipped 1 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_8fqwUJxRIHzSPAL3

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Using JSON.parse to create an object with a dynamic key is unnecessary and can be error-prone. Consider using object literal syntax directly:

Suggested change

	const jsonObj = JSON.parse(`{"apiKey": "${apiKey}"}`);
	const jsonObj = { apiKey: apiKey };

This change simplifies the code and avoids potential parsing errors.