Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactored flood to better behavior #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Sep 2, 2021

I've had this in my working tree for a while. Should be improved behavior better aligned with how aw-server-rust works. Will hopefully fix ActivityWatch/activitywatch#626.

(Needs thorough review, long time since I wrote this, and can't remember what I've done)

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #105 (0b47c01) into master (efd1325) will decrease coverage by 0.62%.
The diff coverage is 69.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   90.78%   90.16%   -0.63%     
==========================================
  Files          34       34              
  Lines        1660     1687      +27     
  Branches      257      262       +5     
==========================================
+ Hits         1507     1521      +14     
- Misses        118      131      +13     
  Partials       35       35              
Impacted Files Coverage Δ
aw_transform/flood.py 75.71% <69.56%> (-14.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd1325...0b47c01. Read the comment docs.

@ErikBjare
Copy link
Member Author

Since this is based on the aw-server-rust implementation, I just want to note that it might not be without issues either: ActivityWatch/activitywatch#602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More time reported than actual usage
1 participant