Fix queries.py Line 119-123

[Shi-Soul]

Fix a simple Operator precedence bug.

browserEvents(params)
if isDesktopParams(params)
else ""
+ (...)

In this code, ""+(...) will be interpreted as a whole.

---

Important

Fix operator precedence issue in canonicalEvents() in queries.py by adding parentheses for correct string concatenation.

• Bug Fix:
  • Fix operator precedence issue in canonicalEvents() in queries.py.
  • Add parentheses around browserEvents(params) if isDesktopParams(params) else "" to ensure correct string concatenation order.

^{This description was created by for 3c7aa33. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 3c7aa33 in 5 seconds

More details

• Looked at 19 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. aw_client/queries.py:119

• Draft comment:
  The fix correctly addresses the operator precedence issue by adding parentheses. However, the nested parentheses can be simplified for better readability:

browserEvents(params) if isDesktopParams(params) else ""

• Reason this comment was not posted:
  Confidence changes required: 10%
  The PR correctly addresses the operator precedence issue by adding parentheses around the conditional expression. This ensures that the concatenation operation is performed correctly. However, there is a potential improvement in readability by simplifying the nested parentheses.

Workflow ID: wflow_BW1MMHKjCTviMVAD

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ErikBjare]

Thanks, nice catch!

Merging.