fix(dereference): cache poisoning when dereferencing external schemas #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
changed the title
erunion
commented
Apr 12, 2025
There was a problem hiding this comment.
Might want to review this with whitespace changes off, I moved some things around because this cache logic was beginning to make my head spin. 🫨
Pull Request Test Coverage Report for Build 14414415087Details
💛 - Coveralls |
|
🎉 This PR is included in version 12.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the fast follow here but I uncovered a bug in #380 while incorporating v12 into our OpenAPI parser. When dereferencing schemas have external references (eg.
$ref: definitions/child.yaml) that$refcould get saved into the dereference cache aschild.yamlresulting in the parent schema ending up with an invalid$refpointer that would bechild.yaml:This case unfortunately was not caught because the
circular-externaltest suite did not have a case fordereference.circular=ignore.I loathe the fix I am submitting here but it resolves this, very unique, case and as we both agree in #380 that the current dereference caching system needs a completely overhaul.