Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Runtime Components in Particle Container #3595

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 16, 2023

Summary

For diagnostics purposes in WarpX, we would like to temporarily add particle runtime components to a particle container, and deallocate them timely again to avoid large memory spikes in I/O.

This adds new functions to remove runtime components.

To Do

  • doc issues in existing AddReal/IntComp: no doxygen, no mention of API contract for allocation
    • for an already allocated species, how does one add-and-allocate only the newly added runtime attributes?
  • deallocation: what does a user need to do after RemoveRealComp/RemoveIntComp to deallocate the memory?

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Add new functions to remove runtime components.
@ax3l ax3l force-pushed the topic-remove-runtime-comps branch from 96ad034 to 08ee44b Compare October 16, 2023 18:55
@ax3l ax3l changed the title RemoveRealComp/RemoveIntComp Temporary Runtime Components in Particle Species Oct 16, 2023
@ax3l ax3l changed the title Temporary Runtime Components in Particle Species Temporary Runtime Components in Particle Container Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants