Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to save the output to a different folder from 'save_dir'. #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gil-i
Copy link

@gil-i gil-i commented Mar 23, 2022

Modified parse_infer_args to add the option '--out_dir' for the path to store the output, inference.py was modified accordingly to use this variable as output directory.
If '--out_dir' is not given this variable sets to '--save_dir' which is a required argument.

Modified parse_infer_args to add the option 'out_dir' for the path to store the output, inference.py was modified accordingly.
@gil-i
Copy link
Author

gil-i commented Mar 23, 2022

Hello @AlbertDominguez I have a use case where I want to run neural admixture multiple times but I want to store the output in different folders with the same name, this is why I want to have an option to directly store the output in the folder I want to, to avoid possible overwrites when running multiple processes of neural admixture at the same time.

Not really sure if the way I set the default value of out_dir to save_dir was the standard way to do it but it should work.

Thanks in advance.

neural_admixture/src/utils.py Outdated Show resolved Hide resolved
@AlbertDominguez AlbertDominguez self-requested a review March 24, 2022 09:38
Copy link
Collaborator

@AlbertDominguez AlbertDominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gil-i , thanks for the request!
While you have added the argument in the parser, it would be unused as it is as the file neural_admixture/src/inference.py in has not been updated to use this new argument. Could you update it too, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants