Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Add a llama2-7b-int8 test config for decode #1284

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

xy12181
Copy link
Collaborator

@xy12181 xy12181 commented Feb 19, 2025

Also add a small accuracy check for the generate text prefix.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@xy12181
Copy link
Collaborator Author

xy12181 commented Feb 19, 2025

To the reviewers: below is my dev work flow.

  • Fork the AI-Hypercomputer/maxtext main branch to my own maxtext repo;
  • For a feature Update unit tests status badge in readme #1, I develop in my private local/feature1 branch;
  • After it is ready for review, I cherry-pick the commit(s) into my public yong/dev1 branch. I only use this branch to submit my code for your review;
  • I address reviewer comments in my local/feature1 branch, and then rebase it to yongx/dev1 branch and force upload -- I keep my yong/dev1 branch history linear with no merges;
  • After your approval, my changes should be squashed into one CL and merged into the main repo's main branch;
  • I will periodically sync the main repo main branch to my own main branch and rebase my feature branch to it;

LMK if this works well for you reviewers. My goal is to keep a simple workflow and help keep the main repo main branch history linear (ideally with no/few merges, but only rebases).

@vipannalla @wyzhang ...

@xy12181
Copy link
Collaborator Author

xy12181 commented Feb 19, 2025

looks good

Thank you @vipannalla for your quick turnaround!

@xy12181
Copy link
Collaborator Author

xy12181 commented Feb 20, 2025

@khatwanimohit, @gobbleturk, @RissyRan, @khatwanimohit could any of you please review and merge this PR? thank you!

Also add a small accuracy check for the generate text prefix.
@vipannalla vipannalla merged commit 3c0be9c into AI-Hypercomputer:main Feb 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants