Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llama3.3-70b-instruct model configs, tests and HF golden logits #1282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hengtaoguo
Copy link
Collaborator

@hengtaoguo hengtaoguo commented Feb 18, 2025

Description

Add support for llama3.3-70b-instruct for maxtext. This model is of the same architecture of llama3.1-70b. Upload golden logits from HuggingFace. Attach converted scanned&unscanned checkpoints paths in 2_test_llama3.3_70b_instruct.sh.

FIXES: b/395908473

Tests

Golden logits match with KL divergence below threshold: screenshot.
Train pipeline works for this model: screenshot.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@hengtaoguo hengtaoguo marked this pull request as ready for review February 19, 2025 00:38
@hengtaoguo hengtaoguo changed the title Add llama3.3-70b-instruct model configs and HF golden logits Add llama3.3-70b-instruct model configs, tests and HF golden logits Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant