[cleanup/fix] Make inference parameters explicit, etc. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xy12181
commented
Feb 19, 2025
•
xy12181
commented
- Rename max_num_seq to batch_size
- Fix a process runner typo
- ......
xy12181
commented
Feb 19, 2025
| @@ -114,7 +114,7 @@ class LinearParallelConfig: | |||
| @dataclasses.dataclass | |||
| class RMSNormParallelConfig: | |||
| mesh: jax.sharding.Mesh | |||
| activation_shared: bool = False | |||
There was a problem hiding this comment.
@zhihaoshan-google: shar_d_ed, not shared. right?
There was a problem hiding this comment.
Correct! sorry for the mistakes.
zhihaoshan-google
approved these changes
Feb 21, 2025
|
@vipannalla could you please help review this PR? |
- Rename max_num_seq to batch_size - Fix a process runner typo - ...... ``` $ python experimental/jax/inference/entrypoint/mini_offline_benchmarking.py Offline inference begins: 2025-02-19 18:51:29.910043 ... Offline inference ends: 2025-02-19 19:15:14.701318 Benchmarking result: Total requests: 24000 Total input tokens: 5311141 Total output tokens: 7030596 Input token thruput: 3727.18 tokens/sec Output token thruput: 4933.84 tokens/sec ```
vipannalla
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.