Yongx/test #191
Closed
Yongx/test #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyzhang
approved these changes
Feb 17, 2025
| pylint "./$folder" | ||
| done | ||
|
|
||
| echo "Successfully clean up all codes." |
There was a problem hiding this comment.
Is existing make format sufficient? In case you are unaware of that.
There was a problem hiding this comment.
Will remove the code style script.
| emb_dim = 8192 | ||
|
|
||
| def test_embedding(self): | ||
| mesh = self.create_device_mesh() |
There was a problem hiding this comment.
nit: self._create_device_mesh. Guide line is _ for private method
| h1_child_0_module.child0 = h2_child_0_module | ||
|
|
||
| parent_module.init_weights() | ||
| print(self.parent_module) |
|
@wyzhang I will address your comments in yongx/dev branch and close this PR. Sorry I am still getting used to the github workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.